Return-path: Received: from oproxy7-pub.bluehost.com ([67.222.55.9]:48695 "HELO oproxy7-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753570Ab1G0QMA (ORCPT ); Wed, 27 Jul 2011 12:12:00 -0400 Date: Wed, 27 Jul 2011 09:11:50 -0700 From: Jesse Barnes To: Stanislaw Gruszka Cc: linux-wireless , ath9k-devel@venema.h4ckr.net, camilo@mesias.co.uk, Jonathan Nieder , Tony Houghton , Rajkumar Manoharan , Adrian Chadd , linux-pci@vger.kernel.org, Jeff Kirsher , e1000-devel@lists.sourceforge.net Subject: Re: [RFC/RFT v2 00/12] ath9k: ASPM fixes Message-ID: <20110727091150.4e517f30@jbarnes-desktop> (sfid-20110727_181205_331563_39FEB027) In-Reply-To: <1311768899-4559-1-git-send-email-sgruszka@redhat.com> References: <1311768899-4559-1-git-send-email-sgruszka@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 27 Jul 2011 14:14:47 +0200 Stanislaw Gruszka wrote: > This patch series try to fix ath9k ASPM. Some of patches are cleanup > only or do merging common code (with e1000e driver). > > With CONFIG_PCIEASPM it's possible to change ASPM settings on runtime > via /sys/module/pcie_aspm/parameters/policy . However most drivers > I looked at assume this setting is constant. I add a callback to pci > driver to inform about the change, and allow driver to do needed hw > related changes. Currently only ath9k implement the callback, but > I think it will be useful for other drivers (i.e. iwlwifi, rtlwifi) > that do some own ASPM handling. > > These patches needs wide testing as they may work on some systems > and not work on others, that can depend on PCIe bridges. These look fine, I remember seeing a place where e1000e could use this just recently and it looks like you took care of it. We may be able to sneak this in to 3.1 to make things easier on the dependent drivers, but it'll have to wait until I send my pull request for the first batch of PCI changes (probably today). -- Jesse Barnes, Intel Open Source Technology Center