Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:35961 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991Ab1GRPHt (ORCPT ); Mon, 18 Jul 2011 11:07:49 -0400 Subject: Re: [PATCH 5/5] mac80211: mesh beacon includes TIM IE From: Johannes Berg To: Javier Cardona Cc: Thomas Pedersen , Jouni Malinen , linux-wireless@vger.kernel.org, linville@tuxdriver.com In-Reply-To: (sfid-20110718_161212_400250_0940E61F) References: <1310600747-9583-1-git-send-email-thomas@cozybit.com> <1310600747-9583-6-git-send-email-thomas@cozybit.com> <20110714062522.GA2534@jm.kir.nu> <1310724023.4164.22.camel@jlt3.sipsolutions.net> (sfid-20110718_161212_400250_0940E61F) Content-Type: text/plain; charset="UTF-8" Date: Mon, 18 Jul 2011 17:07:44 +0200 Message-ID: <1311001664.3942.7.camel@jlt3.sipsolutions.net> (sfid-20110718_170754_014304_1FD75E2C) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2011-07-18 at 07:11 -0700, Javier Cardona wrote: > > I don't think PS support can be hard. We have all of it in AP mode > > anyway, so you just need to generalise that a bit, maybe refactor like I > > said in my other email, and you should be able to get it up & running > > pretty quickly? > > Mesh frame buffering can probably reuse most of the AP mode, yes. The > difficult part is on the receiving STA as it must track the beacon > transmit times of each mesh peer. I don't know how/if we can > implement this in a vendor-neutral mac80211ish sort of way. > > That said, only buffering seems to be mandatory: "A mesh STA SHALL > have the capability to buffer frames and to perform mesh power mode > tracking" but "A mesh STA MAY use mesh power modes to reduce its power > consumption". Right, if you don't want to go to sleep yourself you shouldn't really have big issues different from the current PS code. Of course, you might not have all the nice HW help we have for normal station mode, but mac80211 can already deal with that (filtered frames etc.) Implementing actual powersaving will likely be a bigger issue. johannes