Date: Sat, 30 Jul 2011 13:10:26 -0400 (EDT)
From: Justin Piszcz <jpiszcz@lucidpixels.com>
To: Andreas Hartmann <andihartmann@01019freenet.de>
cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Ivo van Doorn <IvDoorn@gmail.com>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	Alan Piszcz <ap@solarrain.com>,
	"users@rt2x00.serialmonkey.com" <users@rt2x00.serialmonkey.com>
Subject: Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure
In-Reply-To: <alpine.DEB.2.02.1107301305590.4925@p34.internal.lan>
Message-ID: <alpine.DEB.2.02.1107301310070.4925@p34.internal.lan> (sfid-20110730_191032_355617_51E962B8)
References: <alpine.DEB.2.02.1107271851410.25432@p34.internal.lan> <4E318BD0.40202@lwfinger.net> <20110730113009.GA2847@redhat.com> <20110730113255.GB2847@redhat.com> <alpine.DEB.2.02.1107300736010.4925@p34.internal.lan> <alpine.DEB.2.02.1107301015340.4925@p34.internal.lan>
 <alpine.DEB.2.02.1107301031560.4925@p34.internal.lan> <4E341DC4.9010107@01019freenet.de> <alpine.DEB.2.02.1107301305590.4925@p34.internal.lan>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Sender: linux-wireless-owner@vger.kernel.org


On Sat, 30 Jul 2011, Justin Piszcz wrote:

>
>
> On Sat, 30 Jul 2011, Andreas Hartmann wrote:
>
>> Hi Justin,
>> 
>> if you want to test, if the module works stable, run this script for one
>> or two hours. It will stress the driver and the hardware.
>> 
>> If it doesn't crash and if the throughput is stable, you can hope, that
>> the driver is ok for daily work.
>> 
>> 
>> #!/bin/sh
>> 
>> dest="server" # set the servername
>> 
>> while true ; do
>> netperf -t TCP_MAERTS -H $dest
>> netperf -t TCP_STREAM -H $dest
>> netperf -t TCP_SENDFILE -H $dest
>> done
>> 
>> 
>> Start the script on the client. On the server start netserver.
>> You get netperf from http://www.netperf.org/netperf/
>> 
>> 
>> Andreas
>> 
>
> Hello Andreas,
>
> Thanks for the suggestion; however, it is crashing repeatedly after about 
> 5-10 minutes, so it is not needed yet.
>
> Here you go, crash 2:
> http://home.comcast.net/~jpiszcz/20110730/2630-rt2800usb-crash2p1.jpg
> http://home.comcast.net/~jpiszcz/20110730/2630-rt2800usb-crash2p2.jpg
>
> Justin.
>

(This is with the patch provided earlier)

atom:/usr/src/linux# cd drivers/net/wireless/rt2x00/
atom:/usr/src/linux/drivers/net/wireless/rt2x00# grep 'memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE)' rt2800lib.c
         memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE);
atom:/usr/src/linux/drivers/net/wireless/rt2x00# cat /usr/src/linux/.version
2
atom:/usr/src/linux/drivers/net/wireless/rt2x00# uname -a
Linux atom 3.0.0 #2 SMP Sat Jul 30 08:34:18 EDT 2011 x86_64 GNU/Linux
atom:/usr/src/linux/drivers/net/wireless/rt2x00#

Justin.