Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:55787 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420Ab1GWJnO (ORCPT ); Sat, 23 Jul 2011 05:43:14 -0400 Received: by qwk3 with SMTP id 3so1462499qwk.19 for ; Sat, 23 Jul 2011 02:43:13 -0700 (PDT) MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <20110723072113.17363.59871.stgit@mj.roinet.com> References: <20110723072113.17363.59871.stgit@mj.roinet.com> Date: Sat, 23 Jul 2011 11:43:13 +0200 Message-ID: (sfid-20110723_114317_633751_E1FD94D3) Subject: Re: [PATCH 1/3] ath5k: remove unused and write-only structures and fields From: Sedat Dilek To: Pavel Roskin Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org, "John W. Linville" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Jul 23, 2011 at 9:21 AM, Pavel Roskin wrote: > struct ath5k_avg_val is unused. > > In struct ath5k_hw, lladdr, ah_radar and ah_mac_revision are write-only, > rxbufsize is unused, ah_phy is write-only and referenced by unused > macros. > > In struct ath5k_vif, lladdr is write-only. > > Remove AR5K_TUNE_RADAR_ALERT, which has no effect. > > Signed-off-by: Pavel Roskin > Tested on Atheros AR5212 chip against linux-next (next-20110722). Feel free to add: Tested-by: Sedat Dilek - Sedat -