Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:64323 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754716Ab1GDKtC convert rfc822-to-8bit (ORCPT ); Mon, 4 Jul 2011 06:49:02 -0400 Received: by yxi11 with SMTP id 11so1544107yxi.19 for ; Mon, 04 Jul 2011 03:49:01 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4E1199A9.2040008@openwrt.org> References: <1309758467-1712-1-git-send-email-nbd@openwrt.org> <1309758467-1712-2-git-send-email-nbd@openwrt.org> <1309758467-1712-3-git-send-email-nbd@openwrt.org> <1309758467-1712-4-git-send-email-nbd@openwrt.org> <4E1199A9.2040008@openwrt.org> Date: Mon, 4 Jul 2011 13:49:01 +0300 Message-ID: (sfid-20110704_124907_436811_BEA991B0) Subject: Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate From: Nick Kossifidis To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org, linville@tuxdriver.com Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2011/7/4 Felix Fietkau : > On 2011-07-04 5:40 PM, Nick Kossifidis wrote: >> >> 2011/7/4 Felix Fietkau: >>> >>>  Fixes a division by zero when setting distance before activating the >>>  device for the first time. >>> >>>  Signed-off-by: Felix Fietkau >>>  --- >>>   drivers/net/wireless/ath/ath5k/base.c |    1 + >>>   1 files changed, 1 insertions(+), 0 deletions(-) >>> >>>  diff --git a/drivers/net/wireless/ath/ath5k/base.c >>> b/drivers/net/wireless/ath/ath5k/base.c >>>  index a6623dd..a413aa7 100644 >>>  --- a/drivers/net/wireless/ath/ath5k/base.c >>>  +++ b/drivers/net/wireless/ath/ath5k/base.c >>>  @@ -2422,6 +2422,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const >>> struct ath_bus_ops *bus_ops) >>>         common->ah = sc->ah; >>>         common->hw = hw; >>>         common->priv = sc; >>>  +       common->clockrate = 40; >>> >>>         /* >>>          * Cache line size is used to size and align various >>>  -- >>>  1.7.3.2 >>> >> >> We better set this to 44 for g (according to docs core frequency is 44MHz >> for g) > > It shouldn't make a difference, since the first hardware reset will reload > all the settings anyway. > > - Felix > O.K. Acked-by: Nick Kossifidis -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick