Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:53660 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965014Ab1GOKNg convert rfc822-to-8bit (ORCPT ); Fri, 15 Jul 2011 06:13:36 -0400 Received: by iyb12 with SMTP id 12so1018207iyb.19 for ; Fri, 15 Jul 2011 03:13:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4E200B2F.3060108@broadcom.com> References: <1310678971-28952-1-git-send-email-frankyl@broadcom.com> <1310678971-28952-6-git-send-email-frankyl@broadcom.com> <4E200B2F.3060108@broadcom.com> From: Julian Calaby Date: Fri, 15 Jul 2011 20:13:16 +1000 Message-ID: (sfid-20110715_121340_192686_0E739076) Subject: Re: [PATCH 05/35] staging: brcm80211: removed function declaration typedefs from aiutils.h To: Roland Vossen Cc: "Franky (Zhenhui) Lin" , "gregkh@suse.de" , "devel@linuxdriverproject.org" , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Roland, On Fri, Jul 15, 2011 at 19:41, Roland Vossen wrote: > Hello Julian, > >>> Signed-off-by: Roland Vossen >>> Reviewed-by: Arend van Spriel >>> --- >>> diff --git a/drivers/staging/brcm80211/brcmsmac/aiutils.c >>> b/drivers/staging/brcm80211/brcmsmac/aiutils.c >>> index a25901e..5a5fc4b 100644 >>> --- a/drivers/staging/brcm80211/brcmsmac/aiutils.c >>> +++ b/drivers/staging/brcm80211/brcmsmac/aiutils.c >>> @@ -1279,9 +1279,9 @@ ai_register_intr_callback(struct si_pub *sih, void >>> *intrsoff_fn, >>> >>> ? ? ? ?sii = SI_INFO(sih); >>> ? ? ? ?sii->intr_arg = intr_arg; >>> - ? ? ? sii->intrsoff_fn = (si_intrsoff_t) intrsoff_fn; >>> - ? ? ? sii->intrsrestore_fn = (si_intrsrestore_t) intrsrestore_fn; >>> - ? ? ? sii->intrsenabled_fn = (si_intrsenabled_t) intrsenabled_fn; >>> + ? ? ? sii->intrsoff_fn = (u32 (*)(void *)) intrsoff_fn; >>> + ? ? ? sii->intrsrestore_fn = (void (*) (void *, u32)) intrsrestore_fn; >>> + ? ? ? sii->intrsenabled_fn = (bool (*)(void *)) intrsenabled_fn; >>> ? ? ? ?/* save current core id. ?when this function called, the current >>> core >>> ? ? ? ? * must be the core which provides driver functions(il, et, wl, >>> etc.) >>> ? ? ? ? */ >> >> Are these casts necessary - as in could better types be chosen for >> these function pointers and the underlying functions themselves? >> I see the same issue in patches 6 - 10. > > The first goal was to replace the typedefs, in a way that is obvious to the > reviewer. The next step is to get rid of void* where possible (I agree with > you that it is ugly). Fair enough. > Is it ok with you if we submit a separate patch train for that (since there > are quite some void* to be replaced) ? That's fine, I was just drawing your attention to them. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/