Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:32329 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045Ab1HQHHv (ORCPT ); Wed, 17 Aug 2011 03:07:51 -0400 Date: Wed, 17 Aug 2011 12:36:20 +0530 From: Senthil Balasubramanian To: "John W. Linville" CC: "Luis R. Rodriguez" , , Paul Stewart Subject: Re: [PATCH] ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address Message-ID: <20110817070619.GA2139@senthil-lnx.users.atheros.com> (sfid-20110817_090758_372868_1DE7C0EA) References: <1312914178-9601-1-git-send-email-senthilb@qca.qualcomm.com> <20110809184415.GB10104@senthil-lnx.users.atheros.com> <20110812171734.GD2286@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20110812171734.GD2286@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Aug 12, 2011 at 01:17:34PM -0400, John W. Linville wrote: > On Wed, Aug 10, 2011 at 12:14:16AM +0530, Senthil Balasubramanian wrote: > > On Tue, Aug 09, 2011 at 11:32:17AM -0700, Luis R. Rodriguez wrote: > > > On Tue, Aug 9, 2011 at 11:31 AM, Luis R. Rodriguez wrote: > > > > On Tue, Aug 9, 2011 at 11:22 AM, Senthil Balasubramanian > > > > wrote: > > > >> Due to some recent optimization done in the way the mac address > > > >> bytes are written into the OTP memory, some AR9485 chipsets were > > > >> forced to use the first byte from the eeprom template and as AR9485 > > > >> happens to use generic eeprom template which has 0x1 as the first > > > >> byte causes issues in bringing up the card. > > > >> > > > >> So fixed the eeprom template accordingly to address the issue. > > > >> > > > >> Cc: Paul Stewart > > > >> Signed-off-by: Senthil Balasubramanian > > > > > > > > I don't follow the description too well, all I can tell from it is > > > > that there is an issue if the template has 0x01 set instead of 0x0 but > > > > it doesn't tell me why. > > The leading byte is 1 which is obviously incorrect for mac address. > > The reason why 1 is chosen by the driver for mac address is due to > > the way the OTP write was optimized and so the driver has taken the > > first byte alone from the template and the remaining from OTP. > > > > > > > > Is this not a stable fix? > > Oops.. Yes it is. Let me cc to stable. thanks for the stable reminder :-( > > Are you goint to resubmit a patch w/ a better changelog and > Cc: stable@kernel.org? Yes.. John. Sorry! for the long silence from my side. > > John > -- > John W. Linville Someday the world will need a hero, and you > linville@tuxdriver.com might be all we have. Be ready.