Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:61858 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738Ab1H3OKa (ORCPT ); Tue, 30 Aug 2011 10:10:30 -0400 Date: Tue, 30 Aug 2011 17:09:51 +0300 From: Jouni Malinen To: Kalle Valo CC: Subject: Re: [PATCH 04/20] ath6kl: Use change_station() to authorize/unauthorize STAs Message-ID: <20110830140951.GB8163@jouni.qca.qualcomm.com> (sfid-20110830_161033_826954_3C7FA19D) References: <1314620641-24257-1-git-send-email-jouni@qca.qualcomm.com> <1314620641-24257-5-git-send-email-jouni@qca.qualcomm.com> <4E5CA807.4090105@qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <4E5CA807.4090105@qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 30, 2011 at 12:06:15PM +0300, Kalle Valo wrote: > On 08/29/2011 03:23 PM, Jouni Malinen wrote: > > --- a/drivers/net/wireless/ath/ath6kl/wmi.h > > +++ b/drivers/net/wireless/ath/ath6kl/wmi.h > > @@ -1804,6 +1804,21 @@ struct wmi_tx_complete_event { > > +/* > > + * Used with WMI_AP_SET_MLME_CMDID > > + */ > > +struct wmi_ap_set_mlme_cmd { > > + u8 mac[ETH_ALEN]; > > + u16 reason; /* 802.11 reason code */ > > + u8 cmd; /* operation to perform */ > > +/* MLME Commands */ > > +#define WMI_AP_MLME_ASSOC 1 /* associate station */ > > +#define WMI_AP_DISASSOC 2 /* disassociate station */ > > +#define WMI_AP_DEAUTH 3 /* deauthenticate station */ > > +#define WMI_AP_MLME_AUTHORIZE 4 /* authorize station */ > > +#define WMI_AP_MLME_UNAUTHORIZE 5 /* unauthorize station */ > > +} __packed; > > Needs an endian annotation for u16. Also defines inside a struct are > IMHO a bit awkward. Thanks, fixed. -- Jouni Malinen PGP id EFC895FA