Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:23105 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773Ab1H0HIp (ORCPT ); Sat, 27 Aug 2011 03:08:45 -0400 Date: Sat, 27 Aug 2011 12:39:14 +0530 From: Rajkumar Manoharan To: Felix Fietkau CC: , Subject: Re: [PATCH] ath9k_hw: Set default slottime as 9us Message-ID: <20110827070912.GA3140@vmraj-lnx.users.atheros.com> (sfid-20110827_090850_960725_3526C7C6) References: <1314424379-1206-1-git-send-email-rmanohar@qca.qualcomm.com> <4E588E3B.9000007@openwrt.org> <20110827065256.GA3082@vmraj-lnx.users.atheros.com> <4E589704.3090807@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <4E589704.3090807@openwrt.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Aug 27, 2011 at 09:04:36AM +0200, Felix Fietkau wrote: > On 2011-08-27 8:52 AM, Rajkumar Manoharan wrote: > >On Sat, Aug 27, 2011 at 08:27:07AM +0200, Felix Fietkau wrote: > >> On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote: > >> >Initialize 9us slot time as that is what is used mostly > >> >(for non-ERP cases) and also to be in sync with initvals. > >> > > >> >Signed-off-by: Rajkumar Manoharan > >> Why does it matter, mac80211 tells the driver to reconfigure it > >> anyway. Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we > >> should simply remove those. > >> > >In most of the case, mac80211 set as 9us and also initval uses 9us. > >The what is the problem of setting 9us as default. If you want to > >remove ATH9K_SLOT_TIME_* enums, ath9k should not set slottime till > >it got configured. > I don't see a problem with the change aside from the fact that it > should not make any difference at all, so I don't really see any > point to it. > I doubt that using long slottime might affect random backoff. so let it to be in sync with initval till it is altered. am i right? -- Rajkumar