Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:34944 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479Ab1HJSAQ (ORCPT ); Wed, 10 Aug 2011 14:00:16 -0400 Date: Wed, 10 Aug 2011 13:58:27 -0400 From: "John W. Linville" To: Marek Lindner Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net Subject: Re: [PATCHv2] ath9k: remove eeprom txgain override for minor version < 19 Message-ID: <20110810175826.GB25266@tuxdriver.com> (sfid-20110810_200020_214789_DD463600) References: <1312359372-5586-1-git-send-email-lindner_marek@yahoo.de> <1312382116-27257-1-git-send-email-lindner_marek@yahoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1312382116-27257-1-git-send-email-lindner_marek@yahoo.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Aug 03, 2011 at 04:35:16PM +0200, Marek Lindner wrote: > ath9k_hw_4k_get_eeprom() overrides the eeprom value for txgain if the > minor version is not 19 or above with a value of 0. > ar9002_hw_init_mode_gain_regs() relies on this information to > determine whether this is a high power wifi card or not. The override > caused the driver to always use the 'normal' power tables even for > high power devices if their minor version was not high enough. Thus > leading to reduced power output. > > This isn't needed for the AR9285; the check originated with the > AR9280 setup code which requires the EEPROM version check. > > Signed-off-by: Marek Lindner > --- > drivers/net/wireless/ath/ath9k/eeprom_4k.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/eeprom_4k.c b/drivers/net/wireless/ath/ath9k/eeprom_4k.c > index 5b1e894..10f3072 100644 > --- a/drivers/net/wireless/ath/ath9k/eeprom_4k.c > +++ b/drivers/net/wireless/ath/ath9k/eeprom_4k.c > @@ -237,10 +237,7 @@ static u32 ath9k_hw_4k_get_eeprom(struct ath_hw *ah, > case EEP_ANT_DIV_CTL1: > return pModal->antdiv_ctl1; > case EEP_TXGAIN_TYPE: > - if (ver_minor >= AR5416_EEP_MINOR_VER_19) > - return pBase->txGainType; > - else > - return AR5416_EEP_TXGAIN_ORIGINAL; > + return pBase->txGainType; > default: > return 0; > } Any chance for an ACK from someone from Atheros on the ath9k team? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.