Return-path: Received: from bues.ch ([80.190.117.144]:60176 "EHLO bues.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137Ab1HXQGY convert rfc822-to-8bit (ORCPT ); Wed, 24 Aug 2011 12:06:24 -0400 Date: Wed, 24 Aug 2011 18:06:11 +0200 From: Michael =?UTF-8?B?QsO8c2No?= To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, David Woodhouse , Larry Finger Subject: Re: [RFT][PATCH] b43: use 8K buffers for 64-bit DMA to workaround hardware bug Message-ID: <20110824180611.36af5a83@milhouse> (sfid-20110824_180627_684104_4641647F) In-Reply-To: <1314201438-12125-1-git-send-email-zajec5@gmail.com> References: <1314201438-12125-1-git-send-email-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 24 Aug 2011 17:57:18 +0200 Rafał Miłecki wrote: > + /* For unknown reasons - possibly a hardware error - the BCM4311 rev > * 02, which uses 64-bit DMA, needs the ring buffer in very low memory, > * which accounts for the GFP_DMA flag below. > - * > - * The flags here must match the flags in free_ringmemory below! > */ > + gfp_t flags = GFP_KERNEL; > if (ring->type == B43_DMA_64BIT) > flags |= GFP_DMA; Did somebody actually re-evaluate this? I still believe that this is not a hardware error, but rather a software bug in the DMA allocator that probably is fixed already. Larry, I think you added this. Do you still have the device that triggered this? -- Greetings, Michael.