Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:51182 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474Ab1HXOqb (ORCPT ); Wed, 24 Aug 2011 10:46:31 -0400 Date: Wed, 24 Aug 2011 20:16:46 +0530 From: Vasanthakumar Thiagarajan To: Kalle Valo CC: Subject: Re: [PATCH 1/3] ath6kl: Add initial debugfs changes Message-ID: <20110824144644.GD25267@vasanth-laptop> (sfid-20110824_164635_782789_2AF1611A) References: <1314195936-25227-1-git-send-email-vthiagar@qca.qualcomm.com> <4E550D34.7020008@qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <4E550D34.7020008@qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Aug 24, 2011 at 05:39:48PM +0300, Kalle Valo wrote: > On 08/24/2011 05:25 PM, Vasanthakumar Thiagarajan wrote: > > +#ifdef CONFIG_ATH6KL_DEBUGFS > > +int ath6kl_init_debugfs(struct ath6kl *ar); > > +#else > > +static inline int ath6kl_init_debugfs(struct ath6kl *ar) > > +{ > > + return 0; > > +} > > +#endif > > I would prefer to call this ath6kl_debug_init(). That way we can put all > debug initialisation into that, not just debugfs code. And then the > ifdef should check for CONFIG_ATH6KL_DEBUG. May be, but I think we can't always enable debugfs based on only CONFIG_ATH6KL_DEBUG as the general debug does not depend on CONFIG_DEBUG_FS. Vasanth