Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:42115 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469Ab1H3Ikw (ORCPT ); Tue, 30 Aug 2011 04:40:52 -0400 Date: Tue, 30 Aug 2011 11:40:46 +0300 From: Jouni Malinen To: Raja Mani CC: , Subject: Re: [PATCH 01/20] ath6kl: Add functionality for starting AP mode Message-ID: <20110830084046.GC2279@jouni.qca.qualcomm.com> (sfid-20110830_104059_346262_DCF1BB72) References: <1314620641-24257-1-git-send-email-jouni@qca.qualcomm.com> <1314620641-24257-2-git-send-email-jouni@qca.qualcomm.com> <4E5C797F.3090900@qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <4E5C797F.3090900@qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 30, 2011 at 11:17:43AM +0530, Raja Mani wrote: > On Monday 29 August 2011 05:53 PM, Jouni Malinen wrote: > >+static int ath6kl_ap_beacon(struct wiphy *wiphy, struct net_device *dev, > >+ struct beacon_parameters *info, bool add) > >+{ > >+ if (!test_bit(WMI_READY,&ar->flag)) > >+ return -EIO; > >+ > >+ if (!test_bit(WLAN_ENABLED,&ar->flag)) > >+ return -EIO; > > How about calling ath6kl_cfg80211_ready() function to check > WMI_READY and WLAN_ENABLED status ? Sure, I can do that, but unless something else comes up, I would rather do it after the patch series goes in. It looks like I missed addition of that helper function since I started working on this before the cleanup was complete. By the way.. How did that message lost the space after the commas on those test_bit lines? They are included in the patch I sent. -- Jouni Malinen PGP id EFC895FA