Message-ID: <4E5CA423.5020309@qca.qualcomm.com> (sfid-20110830_104959_981691_EC410F37)
Date: Tue, 30 Aug 2011 11:49:39 +0300
From: Kalle Valo <kvalo@qca.qualcomm.com>
MIME-Version: 1.0
To: Jouni Malinen <jouni@qca.qualcomm.com>
CC: Raja Mani <rmani@qca.qualcomm.com>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 01/20] ath6kl: Add functionality for starting AP mode
References: <1314620641-24257-1-git-send-email-jouni@qca.qualcomm.com> <1314620641-24257-2-git-send-email-jouni@qca.qualcomm.com> <4E5C797F.3090900@qca.qualcomm.com> <20110830084046.GC2279@jouni.qca.qualcomm.com>
In-Reply-To: <20110830084046.GC2279@jouni.qca.qualcomm.com>
Content-Type: text/plain; charset="ISO-8859-1"
Sender: linux-wireless-owner@vger.kernel.org

On 08/30/2011 11:40 AM, Jouni Malinen wrote:
> On Tue, Aug 30, 2011 at 11:17:43AM +0530, Raja Mani wrote:
>> On Monday 29 August 2011 05:53 PM, Jouni Malinen wrote:
>>> +static int ath6kl_ap_beacon(struct wiphy *wiphy, struct net_device *dev,
>>> +			    struct beacon_parameters *info, bool add)
>>> +{
> 
>>> +	if (!test_bit(WMI_READY,&ar->flag))
>>> +		return -EIO;
>>> +
>>> +	if (!test_bit(WLAN_ENABLED,&ar->flag))
>>> +		return -EIO;
>>
>> How about calling ath6kl_cfg80211_ready() function to check
>> WMI_READY and WLAN_ENABLED status ?
> 
> Sure, I can do that, but unless something else comes up, I would rather
> do it after the patch series goes in. It looks like I missed addition of
> that helper function since I started working on this before the cleanup
> was complete.

I also prefer that you send a followup patch.

> By the way.. How did that message lost the space after the commas on
> those test_bit lines? They are included in the patch I sent.

Our mail servers seem to be the reason as I see the spaces in the
original patch when I read the patches from my private email.

Kalle