Message-ID: <4E5CBC62.8000307@qca.qualcomm.com> (sfid-20110830_123622_228006_052C1DA3)
Date: Tue, 30 Aug 2011 16:03:06 +0530
From: Raja Mani <rmani@qca.qualcomm.com>
MIME-Version: 1.0
To: Kalle Valo <kvalo@qca.qualcomm.com>
CC: Jouni Malinen <jouni@qca.qualcomm.com>,
	<linux-wireless@vger.kernel.org>,
	Edward Lu <shaol@qca.qualcomm.com>
Subject: Re: [PATCH 11/20] ath6kl: Support channel set request for startscan
 command
References: <1314620641-24257-1-git-send-email-jouni@qca.qualcomm.com> <1314620641-24257-12-git-send-email-jouni@qca.qualcomm.com> <4E5CB5A3.6070507@qca.qualcomm.com> <4E5CBBBA.7080204@qca.qualcomm.com>
In-Reply-To: <4E5CBBBA.7080204@qca.qualcomm.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

On Tuesday 30 August 2011 04:00 PM, Kalle Valo wrote:
> On 08/30/2011 01:04 PM, Raja Mani wrote:
>> On Monday 29 August 2011 05:53 PM, Jouni Malinen wrote:
>>
>>>    	if (ath6kl_wmi_startscan_cmd(ar->wmi, WMI_LONG_SCAN, 0,
>>> -				     false, 0, 0, 0, NULL) != 0) {
>>> +				     false, 0, 0, n_channels, channels) != 0) {
>>>    		ath6kl_err("wmi_startscan_cmd failed\n");
>>
>> kfree(channels) for failure cases ??
>
> It's freed below as there's no return call for the error case:

Oops.. Sorry for the noise..

>
>>>    		ret = -EIO;
>>>    	}
>>>
>>>    	ar->scan_req = request;
>>>
>>> +	kfree(channels);<-----
>>> +
>>>    	return ret;
>>>    }
>
> I also got fooled by this :)
>
> Kalle