Return-path: Received: from mail-yi0-f46.google.com ([209.85.218.46]:40606 "EHLO mail-yi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429Ab1HHVCv convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2011 17:02:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <201107230012.p6N0CZSM002466@hera.kernel.org> Date: Mon, 8 Aug 2011 23:02:50 +0200 Message-ID: (sfid-20110808_230309_712042_9BFD1654) Subject: Re: b43: LCN-PHY add place for new PHY support From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: =?UTF-8?Q?G=C3=A1bor_Stefanik?= Cc: Geert Uytterhoeven , "John W. Linville" , Linux Kernel Mailing List , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 8 sierpnia 2011 18:07 użytkownik Gábor Stefanik napisał: > 2011/8/8 Rafał Miłecki : >> W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven >> napisał: >>> On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List >>> wrote: >>>> Gitweb:     http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3 >>>> Commit:     1d738e64f3d957d56c1b51e64ebdef986a8760e3 >>>> Parent:     0cd20a278e1ef9da9f6a987942794c9d65af8c4d >>>> Author:     Rafał Miłecki >>>> AuthorDate: Thu Jul 7 15:25:27 2011 +0200 >>>> Committer:  John W. Linville >>>> CommitDate: Fri Jul 8 11:11:25 2011 -0400 >>> >>>> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h >>>> new file mode 100644 >>>> index 0000000..c046c2a >>>> --- /dev/null >>>> +++ b/drivers/net/wireless/b43/phy_lcn.h >>> >>>> \ No newline at end of file >>> >>> Woops... >>> >>> gcc/cpp also complains: >>> >>> drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file >> >> Sorry, I didn't know we want empty lines at the end. I also don't >> think it's mentioned in kernel's CodingStyle. > > I'm pretty sure it is basic Unix knowledge that all text files SHOULD > (RFC 2119) end with a newline character, unless otherwise noted > explicitly. In fact, many Unix text editors automatically insert a > newline at the end, and forbid you from deleting it. OK, thanks, will avoid that in the future. -- Rafał