Return-path: Received: from mail-pz0-f42.google.com ([209.85.210.42]:58601 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343Ab1HSVSf convert rfc822-to-8bit (ORCPT ); Fri, 19 Aug 2011 17:18:35 -0400 Received: by pzk37 with SMTP id 37so5459213pzk.1 for ; Fri, 19 Aug 2011 14:18:34 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1313787142.6210.9.camel@shinybook.infradead.org> References: <4E3420E9.6080603@lwfinger.net> <1313617419.3990.134.camel@shinybook.infradead.org> <1313653897.13224.4.camel@shinybook.infradead.org> <1313787142.6210.9.camel@shinybook.infradead.org> Date: Fri, 19 Aug 2011 23:17:48 +0200 Message-ID: (sfid-20110819_231838_745313_3B42B3B1) Subject: Re: [PATCH] Add uevent to bcma bus, to autoload drivers. From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: David Woodhouse Cc: wireless , b43-dev , Larry Finger Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 19 sierpnia 2011 22:52 użytkownik David Woodhouse napisał: > On Fri, 2011-08-19 at 22:13 +0200, Rafał Miłecki wrote: >> I can accept sending patch directly to John, if I'm included in CC and >> linux-wireless is included as well. > > But if b43 isn't ready for *some* bcma card, so you don't want it > autoloading, then perhaps we might have wanted to remove a MODULE_ALIAS > from b43 to prevent it being autoloaded for just *that* device. Or > something like that. So even for this "obviously correct" patch I'd > rather run it by you first. There is nothing wrong in auto-loading b43 for unsupported card. b43 will detect the PHY type is not supported and will return false from probing function. -- Rafał