Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:38552 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455Ab1HHM0b convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2011 08:26:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <201107230012.p6N0CZSM002466@hera.kernel.org> Date: Mon, 8 Aug 2011 14:26:30 +0200 Message-ID: (sfid-20110808_142636_657060_B6036F5A) Subject: Re: b43: LCN-PHY add place for new PHY support From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Geert Uytterhoeven Cc: "John W. Linville" , Linux Kernel Mailing List , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven napisał: > On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List > wrote: >> Gitweb:     http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3 >> Commit:     1d738e64f3d957d56c1b51e64ebdef986a8760e3 >> Parent:     0cd20a278e1ef9da9f6a987942794c9d65af8c4d >> Author:     Rafał Miłecki >> AuthorDate: Thu Jul 7 15:25:27 2011 +0200 >> Committer:  John W. Linville >> CommitDate: Fri Jul 8 11:11:25 2011 -0400 > >> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h >> new file mode 100644 >> index 0000000..c046c2a >> --- /dev/null >> +++ b/drivers/net/wireless/b43/phy_lcn.h > >> \ No newline at end of file > > Woops... > > gcc/cpp also complains: > > drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file Sorry, I didn't know we want empty lines at the end. I also don't think it's mentioned in kernel's CodingStyle. I'll fix that when doing LCN stuff, if you agree separated patch is not needed. My gcc didn't complain :| -- Rafał