Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:46093 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991Ab1INGnR (ORCPT ); Wed, 14 Sep 2011 02:43:17 -0400 Date: Wed, 14 Sep 2011 12:13:52 +0530 From: Rajkumar Manoharan To: Paul Stewart CC: , Subject: Re: [PATCH] ath9k_hw: Do full chip reset on 11A channels Message-ID: <20110914064352.GA27319@vmraj-lnx.users.atheros.com> (sfid-20110914_084327_946707_FB2E6CC6) References: <1315927132-21716-1-git-send-email-rmanohar@qca.qualcomm.com> <20110913171308.GA21972@vmraj-lnx.users.atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Sep 13, 2011 at 10:38:16AM -0700, Paul Stewart wrote: > On Tue, Sep 13, 2011 at 10:13 AM, Rajkumar Manoharan > wrote: > > On Tue, Sep 13, 2011 at 09:01:29AM -0700, Paul Stewart wrote: > >> On Tue, Sep 13, 2011 at 8:18 AM, Rajkumar Manoharan > >> wrote: > >> > AR9003 seems to have issues sometimes with fast channel change > >> > in 5GHz and this case is handled specifically for AR9002 by doing > >> > a full reset. So let's do a full reset for 5GHz channles for all > >> > chipsets. > >> > >> I'm not sure I understand. ?Are you asserting that AR9002 does not > >> need a full reset for channel change in 2GHz? ? The code before your > >> change would fall through for AR_SREV_9280(ah) && !AR_DEVID_7010(ah) > >> whether in 2HGz or 5GHz, but that case gets removed with your change. > >> Is that intentional? > >> > > Yes. Fast channel change is completely supported on 2GHz band. And also > > if you look at the log history, the fast channel change was initially > > disabled in 5GHz alone for AR9280 chips. AR7010 chip is the usb version of > > AR9280. Instead of adding chip specific checks, the fastcc is disabled for > > 5GHz. > > I might not be finding the right part of the history. I do see things > like 0a475cc6a0ac8e38ac3587cff87026551800b7fe: Vasanthakumar > Thiagarajan "ath9k: Do a full reset for AR9280; > AR9280 requires a full reset during channel change and HW reset. > Currently, a fast channel change is done. This patch fixes this bug." > This patch disabled fast-channel-change for the 9280 AND 2GHz channels > (what I assume 5MHZ_SPACED to be filtering). I still see no point in > history where 9280 was enabled for fast channel change in 2Ghz. > True. Let me check on this. Meanwhile I will send v2 patch to disable fastcc on 11A for AR9380 alone. -- Rajkumar