Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:54141 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932690Ab1IOXVR (ORCPT ); Thu, 15 Sep 2011 19:21:17 -0400 Subject: Re: [PATCH] iwlagn: Convert kzalloc to kcalloc From: Joe Perches To: "Luis R. Rodriguez" Cc: wwguy , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Date: Thu, 15 Sep 2011 16:21:16 -0700 In-Reply-To: References: <1316112414-6341-1-git-send-email-wey-yi.w.guy@intel.com> <1316112414-6341-9-git-send-email-wey-yi.w.guy@intel.com> <1316115470.11236.1.camel@Joe-Laptop> <1316112830.19293.4.camel@wwguy-huron> <1316116047.11236.8.camel@Joe-Laptop> <1316127246.7631.2.camel@wwguy-ubuntu> <1316128469.12897.4.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Message-ID: <1316128877.12897.6.camel@Joe-Laptop> (sfid-20110916_012123_944442_E8631364) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2011-09-15 at 16:18 -0700, Luis R. Rodriguez wrote: > On Thu, Sep 15, 2011 at 4:14 PM, Joe Perches wrote: > > On Thu, 2011-09-15 at 15:54 -0700, wwguy wrote: > >> On Thu, 2011-09-15 at 12:47 -0700, Joe Perches wrote: > >> > Convert kzalloc to kcalloc, coalesce multiple lines too. > >> IIRC, there is no real different between kcalloc and kzalloc, I think > >> kcalloc will call kzalloc; both zero out the memory before return. > > Multiplication overflow protection. > Then the patch should explain that, no? Egads. I think not. It's trivially obvious.