Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:61927 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932690Ab1IOXTJ (ORCPT ); Thu, 15 Sep 2011 19:19:09 -0400 Received: by qyk7 with SMTP id 7so3599180qyk.19 for ; Thu, 15 Sep 2011 16:19:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1316128469.12897.4.camel@Joe-Laptop> References: <1316112414-6341-1-git-send-email-wey-yi.w.guy@intel.com> <1316112414-6341-9-git-send-email-wey-yi.w.guy@intel.com> <1316115470.11236.1.camel@Joe-Laptop> <1316112830.19293.4.camel@wwguy-huron> <1316116047.11236.8.camel@Joe-Laptop> <1316127246.7631.2.camel@wwguy-ubuntu> <1316128469.12897.4.camel@Joe-Laptop> From: "Luis R. Rodriguez" Date: Thu, 15 Sep 2011 16:18:49 -0700 Message-ID: (sfid-20110916_011913_925698_D83F4A24) Subject: Re: [PATCH] iwlagn: Convert kzalloc to kcalloc To: Joe Perches Cc: wwguy , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Sep 15, 2011 at 4:14 PM, Joe Perches wrote: > On Thu, 2011-09-15 at 15:54 -0700, wwguy wrote: >> On Thu, 2011-09-15 at 12:47 -0700, Joe Perches wrote: >> > Convert kzalloc to kcalloc, coalesce multiple lines too. >> IIRC, there is no real different between kcalloc and kzalloc, I think >> kcalloc will call kzalloc; both zero out the memory before return. > > Multiplication overflow protection. Then the patch should explain that, no? Luis