Return-path: Received: from nbd.name ([46.4.11.11]:37676 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756342Ab1I2NGd (ORCPT ); Thu, 29 Sep 2011 09:06:33 -0400 Message-ID: <4E846D4F.1070900@openwrt.org> (sfid-20110929_150636_661222_413636E6) Date: Thu, 29 Sep 2011 15:06:23 +0200 From: Felix Fietkau MIME-Version: 1.0 To: Rajkumar Manoharan CC: linville@tuxdriver.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/2] ath9k: Choose highest rate of MRR based on IEEE80211_TX_CTL_USE_MINRATE References: <1317295446-20749-1-git-send-email-rmanohar@qca.qualcomm.com> <4E845733.1000203@openwrt.org> <20110929121426.GA20802@vmraj-lnx.users.atheros.com> In-Reply-To: <20110929121426.GA20802@vmraj-lnx.users.atheros.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2011-09-29 2:14 PM, Rajkumar Manoharan wrote: > On Thu, Sep 29, 2011 at 01:32:03PM +0200, Felix Fietkau wrote: >> On 2011-09-29 1:24 PM, Rajkumar Manoharan wrote: >> >Select appropriate rate as highest rate of rate series, if the frame >> >was asked to be sent at minimum rate. For example nullfunc frames >> >either can be sent at HT rates on normal case or at non-HT rates if >> >it is used for connection monitoring. >> > >> >Signed-off-by: Rajkumar Manoharan >> >--- >> > drivers/net/wireless/ath/ath9k/rc.c | 4 ++-- >> > 1 files changed, 2 insertions(+), 2 deletions(-) >> > >> Shouldn't the check for IEEE80211_TX_CTL_USE_MINRATE be in >> rate_control_send_low(), so that it does not have to be repeated in >> every single rate control module? >> > But I donno what could be the side effect of changing rate_control_send_low > as it is used by all drivers. And also if the rate control provide the > minrate, it can be used to update the PER upon tx status. isnt it? It always updates the PER upon tx status, even if rate_control_send_low was used. It should work the same way for every driver, so I think putting this in the ath9k rc is the wrong place, and it would be weird if a flag with such a generic name as IEEE80211_TX_CTL_USE_MINRATE would be used by some rate control modules and ignored by others. - Felix