Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:61313 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295Ab1ITSp7 convert rfc822-to-8bit (ORCPT ); Tue, 20 Sep 2011 14:45:59 -0400 MIME-Version: 1.0 In-Reply-To: <4E78CFC0.4020003@xenotime.net> References: <20110920173102.d38155c7defbbc29beaae7c0@canb.auug.org.au> <4E78CFC0.4020003@xenotime.net> Date: Tue, 20 Sep 2011 20:45:57 +0200 Message-ID: (sfid-20110920_204621_986879_0567EE46) Subject: Re: [PATCH -next] bcma: needs export.h From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Randy Dunlap , Andrew Morton Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2011/9/20 Randy Dunlap : > From: Randy Dunlap > > bcma/driver_chipcommon_pmu.c needs to include , > so add it to the headers that are included by bcma_private.h. Please take a look at discussion in: [PATCH -next] bcma: main.c needs to include thread (by Andrew). I believe that according to the discussion, such a includes should be done in .c files. Andrew: can you comment? Am I right? -- RafaƂ