Return-path: Received: from oproxy8-pub.bluehost.com ([69.89.22.20]:36907 "HELO oproxy8-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751018Ab1IUVtI (ORCPT ); Wed, 21 Sep 2011 17:49:08 -0400 Message-ID: <4E7A5BD2.40502@xenotime.net> (sfid-20110921_234937_238037_AE23F352) Date: Wed, 21 Sep 2011 14:49:06 -0700 From: Randy Dunlap MIME-Version: 1.0 To: Larry Finger CC: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Andrew Morton , Stephen Rothwell , linux-next@vger.kernel.org, LKML , "linux-wireless@vger.kernel.org" , Paul Gortmaker Subject: Re: [PATCH -next] bcma: main.c and driver_mips.c need linux/export.h References: <20110920173102.d38155c7defbbc29beaae7c0@canb.auug.org.au> <4E78CFC0.4020003@xenotime.net> <4E78FCDB.1010002@xenotime.net> <4E7A084C.3000304@xenotime.net> <4E7A521B.50104@xenotime.net> <4E7A5A2F.7030402@lwfinger.net> In-Reply-To: <4E7A5A2F.7030402@lwfinger.net> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/21/2011 02:42 PM, Larry Finger wrote: > On 09/21/2011 04:07 PM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> main.c and driver_mips.c use EXPORT_SYMBOL() etc. >> so they should include. >> >> Signed-off-by: Randy Dunlap > > From this commit message, it appears that every routine that uses EXPORT_SYMBOL() will need to include this header. I looked at modifying rtlwifi and friends to include this header, but found that include/linux/export.h does not exist in any of my source trees. From that I assume that the change will happen in 3.2. > > I have prepared a patch, but cannot use it at the moment. Is there somewhere that I should send it? Hi Larry, linux/export.h is only in linux-next. I think that you should just prepare a linux-next patch for rtlwifi and then push it after Paul Gortmaker's module.h-split git tree has been merged (it splits module.h into module.h and export.h), or maybe you could ask Paul to merge your patch into his tree. [I added Paul to the cc: list.] -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***