Return-path: Received: from mail-qw0-f42.google.com ([209.85.216.42]:47310 "EHLO mail-qw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755169Ab1ISWMm convert rfc822-to-8bit (ORCPT ); Mon, 19 Sep 2011 18:12:42 -0400 Received: by qwi4 with SMTP id 4so18990812qwi.1 for ; Mon, 19 Sep 2011 15:12:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4E77BC58.7040204@openwrt.org> References: <1316453903-75710-1-git-send-email-nbd@openwrt.org> <1316453903-75710-2-git-send-email-nbd@openwrt.org> <4E77AAFB.1080805@openwrt.org> <4E77B25D.9070907@openwrt.org> <4E77BC58.7040204@openwrt.org> From: "Luis R. Rodriguez" Date: Mon, 19 Sep 2011 15:12:22 -0700 Message-ID: (sfid-20110920_001246_104169_B255EE89) Subject: Re: [PATCH v2 2/4] ath9k_hw: clean up tx power handling To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Sep 19, 2011 at 3:04 PM, Felix Fietkau wrote: > On 2011-09-19 11:54 PM, Luis R. Rodriguez wrote: >> >> On Mon, Sep 19, 2011 at 2:45 PM, Luis R. Rodriguez >>  wrote: >>> >>>  On Mon, Sep 19, 2011 at 2:21 PM, Felix Fietkau  wrote: >>>> >>>>  I looked at the other ath driver and I see no indication that it's >>>> related >>>>  to DFS in any way. >>> >>>  I have verified this just now as well, it seems it was only used to >>>  support an ioctl to userspace to enable users to update a tpscale >>>  value but I see no documentation about this. Next question is who in >>>  usersapce sets this. I wonder if its done through userspace after >>>  measuring some TPC reports from STAs. >> >> So this comes from supporting a "TR-098" specification, which seems to >> be the "Internet Gateway Device data model for the CPE WAN Management >> Protocol". I haven't yet been able to map this to the specification >> respective component: >> >> http://www.broadband-forum.org/technical/download/TR-098.pdf > > Interesting. That definitely supports my point that ath9k is the wrong place > for something like this to be. Let's just get rid of it. Yeah, I'm now convinced :) die code. But please do add some blurb about this tumor the code had. Luis