Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:52788 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682Ab1ISUae (ORCPT ); Mon, 19 Sep 2011 16:30:34 -0400 Date: Mon, 19 Sep 2011 16:29:55 -0400 From: "John W. Linville" To: Felix Fietkau Cc: "Luis R. Rodriguez" , linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 3/4] ath: remove ath_regulatory::current_rd_ext Message-ID: <20110919202955.GE2608@tuxdriver.com> (sfid-20110919_223039_742801_8B2F7EDE) References: <1316453903-75710-1-git-send-email-nbd@openwrt.org> <1316453903-75710-2-git-send-email-nbd@openwrt.org> <1316453903-75710-3-git-send-email-nbd@openwrt.org> <4E778A1C.5020206@openwrt.org> <4E779076.2030509@openwrt.org> <4E7791F5.5050709@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4E7791F5.5050709@openwrt.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Sep 19, 2011 at 09:03:17PM +0200, Felix Fietkau wrote: > On 2011-09-19 8:58 PM, Luis R. Rodriguez wrote: > >On Mon, Sep 19, 2011 at 11:56 AM, Felix Fietkau wrote: > >> On 2011-09-19 8:43 PM, Luis R. Rodriguez wrote: > >>> > >>> On Mon, Sep 19, 2011 at 11:29 AM, Felix Fietkau wrote: > >>>> > >>>> On 2011-09-19 8:18 PM, Luis R. Rodriguez wrote: > >>>>> > >>>>> On Mon, Sep 19, 2011 at 10:38 AM, Felix Fietkau > >>>>> wrote: > >>>>>> > >>>>>> Signed-off-by: Felix Fietkau > >>>>> > >>>>> Can you document on the patch commit log why you do remove this. > >>>> > >>>> Because it's unused > >>> > >>> Why is it unused? > >> > >> Because the code that used to use it was removed a while ago in other > >> patches. > > > >And what did that do :) ? > It used to set some pointless flags that were never used for anything. I think he is prodding you to repost with an updated changelog... -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.