Return-path: Received: from mail-qw0-f45.google.com ([209.85.216.45]:40279 "EHLO mail-qw0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298Ab1IARCC (ORCPT ); Thu, 1 Sep 2011 13:02:02 -0400 Received: by qwj8 with SMTP id 8so1473333qwj.4 for ; Thu, 01 Sep 2011 10:02:01 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1314833554-40721-3-git-send-email-nbd@openwrt.org> References: <1314833554-40721-1-git-send-email-nbd@openwrt.org> <1314833554-40721-2-git-send-email-nbd@openwrt.org> <1314833554-40721-3-git-send-email-nbd@openwrt.org> From: "Luis R. Rodriguez" Date: Thu, 1 Sep 2011 10:01:40 -0700 Message-ID: (sfid-20110901_190206_332119_A5D0C28E) Subject: Re: [PATCH v11 3/4] ath9k: merge reset related functions To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com, rmanohar@qca.qualcomm.com, shafi.wireless@gmail.com, vthiagar@qca.qualcomm.com Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Aug 31, 2011 at 4:32 PM, Felix Fietkau wrote: > reduces unnecessary code duplication. Also takes the sc_pcu_lock within > ath_reset instead of callsites, which makes it possible to always cancel > all queued work items before the reset, possibly fixing a few race > conditions (work items vs reset) along with it. > > Signed-off-by: Felix Fietkau This was a bit hard to review, if helpers are being added can they be added without changing code around, and in some other patch make the changes you describe? Luis