Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:3173 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375Ab1IZS0q (ORCPT ); Mon, 26 Sep 2011 14:26:46 -0400 Message-ID: <4E80C3CE.9010001@broadcom.com> (sfid-20110926_202655_050519_B73CFB0A) Date: Mon, 26 Sep 2011 20:26:22 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: "Johannes Berg" cc: "Franky (Zhenhui) Lin" , "gregkh@suse.de" , "devel@linuxdriverproject.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH 09/20] staging: brcm80211: use endian annotated structures in brcmsmac References: <1316830148-28661-1-git-send-email-frankyl@broadcom.com> <1316830148-28661-10-git-send-email-frankyl@broadcom.com> ( sfid-20110924_040943_301385_9930B29B) <1316860721.3952.5.camel@jlt3.sipsolutions.net> <4E7DCE39.1010406@broadcom.com> <1317029844.4117.31.camel@jlt3.sipsolutions.net> In-Reply-To: <1317029844.4117.31.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/26/2011 11:37 AM, Johannes Berg wrote: > On Sat, 2011-09-24 at 14:34 +0200, Arend van Spriel wrote: >> On 09/24/2011 12:38 PM, Johannes Berg wrote: >>> On Fri, 2011-09-23 at 19:08 -0700, Franky Lin wrote: >>>> struct d11rxhdr { >>>> u16 RxFrameSize; >>>> u16 PAD; >>>> + union { >>>> + struct d11rxhdr_le rxh_le; >>>> + struct d11rxhdr rxh_cpu; >>>> + }; >>> This seems a little strange. Why would it be both in LE and CPU byte >>> order? >> Indeed. When we receive it from the device it is in LE and we convert it >> to CPU order for further processing using rxh_cpu. > That seems a confusing and error-prone -- you'll have to remember > whether you're before or after conversion. Would it be possible to have > two versions of the outer structure and change the pointer type at that > point? > > johannes For me knowing the driver design (a little ;-) it is not difficult to remember. Your feedback has valid arguments so I will reconsider. Franky is looking whether dropping it will affect the other patches submitted to Greg. Gr. AvS