Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:24344 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254Ab1IBIVa (ORCPT ); Fri, 2 Sep 2011 04:21:30 -0400 Message-ID: <4E609204.5080300@qca.qualcomm.com> (sfid-20110902_102137_482409_48C19ABD) Date: Fri, 2 Sep 2011 11:21:24 +0300 From: Kalle Valo MIME-Version: 1.0 To: Vasanthakumar Thiagarajan CC: Subject: Re: [PATCH V3] ath6kl: ath6kl: Add debugfs interface to dump diagnostic registers References: <1314871752-13740-1-git-send-email-vthiagar@qca.qualcomm.com> <4E608BD7.5060104@qca.qualcomm.com> <20110902080100.GA5883@vasanth-laptop> In-Reply-To: <20110902080100.GA5883@vasanth-laptop> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/02/2011 11:01 AM, Vasanthakumar Thiagarajan wrote: > On Fri, Sep 02, 2011 at 10:55:03AM +0300, Kalle Valo wrote: >> On 09/01/2011 01:09 PM, Vasanthakumar Thiagarajan wrote: >> >> Thanks, applied. But I did minor changes: >> >> commit 91d57de5adfc40184ef7cb8974104459c5211add >> Author: Vasanthakumar Thiagarajan >> Date: Fri Sep 2 10:40:06 2011 +0300 >> >> ath6kl: Add debugfs interface to dump diagnostic registers from firmware >> >> To dump a particular register: >> >> echo > /ieee80211/phyX/ath6kl/reg_addr >> >> To dump the entire register set: >> >> echo 0 > /ieee80211/phyX/ath6kl/reg_addr >> >> Register values will be available at: >> >> cat /ieee80211/phyX/ath6kl/reg_dump >> >> kvalo: commit log cleanup, renamed few functions, removed a warning >> message > > Thanks, what is the warning? I just removed the ath6kl_warn() about invalid register address in ath6kl_dbg_is_diag_reg_valid(). Kernel should not send any debug logs in that case. > Did you apply my other patch which fixes endianess?. No, not yet. I still have patches pending for review. Will finish them today. Kalle