Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:2247 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495Ab1JMScx (ORCPT ); Thu, 13 Oct 2011 14:32:53 -0400 Message-ID: <4E972EC7.70400@broadcom.com> (sfid-20111013_203300_914327_0ED645B0) Date: Thu, 13 Oct 2011 20:32:39 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: "John W. Linville" cc: "Luis R. Rodriguez" , "linux-wireless@vger.kernel.org" , "Alwin Beukers" Subject: Re: [PATCH 22/22] brcm80211: removed file wifi.c References: <1318445492-24207-1-git-send-email-arend@broadcom.com> <1318445492-24207-23-git-send-email-arend@broadcom.com> <4E96A696.9040607@broadcom.com> <20111013182306.GD2504@tuxdriver.com> In-Reply-To: <20111013182306.GD2504@tuxdriver.com> Content-Type: multipart/signed; boundary=------------enigA81BDCC464C6403861A9A5E2; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-wireless-owner@vger.kernel.org List-ID: --------------enigA81BDCC464C6403861A9A5E2 Content-Type: multipart/mixed; boundary="------------030805080401000908060906" This is a multi-part message in MIME format. --------------030805080401000908060906 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/13/2011 08:23 PM, John W. Linville wrote: > On Thu, Oct 13, 2011 at 11:08:15AM -0700, Luis R. Rodriguez wrote: >> On Thu, Oct 13, 2011 at 1:51 AM, Arend van Spriel = wrote: >>> On 10/12/2011 11:54 PM, Luis R. Rodriguez wrote: >>>> On Wed, Oct 12, 2011 at 11:51 AM, Arend van Spriel wrote: >>>>> From: Alwin Beukers >>>>> >>>>> Wifi.c was empty after previous cleanups, so it was removed. >>>>> >>>>> Reviewed-by: Arend van Spriel >>>>> Signed-off-by: Arend van Spriel >>>> >>>> Heh, remove Reviewed-by dude. >>>> >>>> Luis >>>> >>> >>> I had a remark on this in earlier commits. So I am clearly missing th= e >>> point here. The author submitted this change and others for review to= me >>> and I reviewed it as requested. Hence the Reviewed-by: entry. >>> >>> I have been given the task to publish these patches and I sign them o= ff >>> for the "Developer's Certificate of Origin". Hence the Signed-off-by:= entry. >>> >>> Is there something wrong with this reasoning? >> >> Yeah this all makes no sense. If someone submits you a patch for you >> to review *and* push upstream you simply add *their* SOB first, and >> then after that your own. >=20 > For my $0.02, having both a Reviewed-by and a Signed-off-by looks > a little funny, but it isn't necessarily wrong. The Signed-off-by > really only says that you believe that patch is legally contributed. >=20 > Oh, and IANAL... >=20 > John IANALE Gr. AvS --------------030805080401000908060906 Content-Type: application/pgp-keys; name="0xB5E1A116.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0xB5E1A116.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.4.11 (GNU/Linux) mQINBE6PPIYBEAC64ntCiEHcX4ldkBRmvFDnGBaMB3kTLSfOIY7Sl1BNBOooBd12 IAVv0rqlPwhlFehULl0zMMg1WrRZGfbNc79yhJxkjISdOXCFnhGoM+sUYpI8rGuv W5KiiKLlekZzTNlFRWROO4o2tr8A5/7TTX+BnNWxe3Kxdukpo2G4TPZ7reTa1F0c hbPg3oWAbQvyKaHfxoptX65K+pi5XOctqKZkgh8uERgPZXu8JNcoIyBm5b1uMFpM NROIRjwDsOsaeuKuJNz+PR/fh49nDOOmfzA+66Exe2TqGj2aSJ467XvP8fl1CqDT LGkCJJtH2IbIcNE2xovfwSXA6/dIknDfxnLZb3c6S9Hmb6aiNLY1XYn5EpBafznJ au0vd6AUMzjeUMlHx5OVmFVZRSjLPx7m0PiO/2kpq7qFXP5MLvT/E1S1mupbqsF3 sQlK3mFmJbkg2vqkmNp+Kd361lHNWA0/3RfnMiLaR5Z/buFjYhqqssFjRGEHKARB BEjV2Vz+LX+vu6K8xFhLLcINlwk6d1UHYxqb0XJRap93Pos+urlUMmlICVNvSSZn Etp1xwXu6UfcU3/k/pGKQJo8hNMRY5lynZDvMSgJs2C6e79o/dkqS1P44rwiRXZZ 8TvrjTQexQA5smkWq9leAQRRlMxlms1nkXuSjEFdD+MYvsXW16cU3gbzAQARAQAB tCVBcmVuZCB2YW4gU3ByaWVsIDxhcmVuZEBicm9hZGNvbS5jb20+iQI4BBMBAgAi BQJOjzyGAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRC3BMfxteGhFjFB D/9hokTANGm6G8XL/NbE6hD8D1VImdYiVv7EfSA2laHmuQBYhG9Md8NiCrJPPrIG MG+Zok4T7waATJ3PgiZXC7xyQhQWzWpNa5TVRyWgpI4ufJwjy1EB11+iN0onGIY9 fN7Hcz2G5xVU0TsKR8J82syV/vVxIG+PRtTcvKqlMgttZL6Dug/axowfs33HtU7n wfjgO/qqqrWL59dRE44aL8U21cON5+L4Fx8kYBV377aI9bJcBQRMS0fGBGF4Ng2B GfipAJHEV/zPwgWvmrwClw8W0j4Fd/Q52HE8NJL1X8YeWqLO+ZKA0CizGD3LM8U0 V7MYoz73NRNwBaK7dCQ1QFulYOyXx7qW7UGSKNfqAfwA+69RdXL5JIvS41nstaUl f7o8pL5Vc9Ir5rPiKf6u+4HU0fEMhMLcpg/mTaJXJNVd8Hi8XV6k5l/HScVYJhR9 X/xIQd304rnGIuEB4FW+dTj/6Asz8mHljuT44zRqfsW+xcoSx73QM4kIZzxAcCHq Z8RYCmJUhAhmj82D32YbpjW589tG8Wyf/SzMcouLbSaULPgIHMr3Q6Y94Fg49Mvo /Qt/oasuaVBgaumF9K/VdSw5hs1eQ0qbm/CFJQYVuH+5aJLiI/dcexd1r/C0ACGw tltEA7EQ4s9nJjC1U0izaFnjGjnvAK0MsAlenwkERhTcjbkCDQROjzyGARAApgDs 8SoVBByE/fKsaCQPmGwUVY2uyLZZgyxEOZB2SafzhNxWi5lW+r8sfVNXmxLoYTW/ +87LpnSFWSLnzwsuUZlnrZ3nHiesiUpX9nQ/wtIOEqBkGY313TPAUb89qECZUuaZ hkwVCHCxWrFoxKSi6plW5/ZRTXnOlY5shRmI2aOQ1rF+c/abaao9iTdSsygwBI05 tIIbCDJlpCnX6LDiU2SwCHEGTyv0uiBr/qAekSN0ykvZ22pUN4psNc3AWsMi5EpZ XZ0bTw19p9u/jwsOhnpKc7A9+qhMxP+vnj+GdLQG2HAGu+sINuPbNlauOQhenA8k zoY/wFOLCoeuxNyNvmLGBm7/JMSy1bImT79fvbcH2HS3sTCfjh2poUvUnDFVaLmD EBf2KmOz1gMWo8QZ/XmhUavE7gFJHLONnhsCDRmbBm4lifvgd+Tr53NPxxxUNAQA h+6WIxFnRK4cxn889BfxUP31V/ir4CiU2T/+aajg4tvgk1pGQx8QQIZEpkjtT0Kh iJwxOvv9BIIMyBwiymRcOuBkaBw9oUiNIc5He/tOWTPvX97mOh0bZrbQ8yJJD5M5 9nJrN+9vOnbE9d8MrMiHd5mbpbNtEDoEPP6lZmTtILv8ooc9q5wLYtmCIIdgHWWc BHjdQm1VQLfsUh2Aj+b8E2pWrVW/4wZxSW0yqRkAEQEAAYkCHwQYAQIACQUCTo88 hgIbDAAKCRC3BMfxteGhFjR5D/9tvr3Vp6IVnEm9PgWbGetemO+M9jfFT69Vkq01 KJcsa+XOu7bVNEznyl1Ieou8ELzKmRnQJNe1PLsv18gPYoNnpZ2w8Z1Z88W1VrC4 uX0BdiNsipyyZE0tBkVVs8FsFekYmWl0LtfE4GqGHm7Q1ezvF3FDT2dMBOT+0Iz+ koIX9PQlwQDzry/Du+crRGOcww9k89qtTO2goYXzXSmtcNcTGwXkTOlbf3A/PSyk nR4CA3Z5EFP5NVTXpS4n32Yg7zI4VXf9iZPYKQhNUACWRCRf1CJIv8/eo6ho1OIv jD2gopmG6nsTdCTdjQRp00paBBonAY6wOZxZCCvZf/EZIcTxGW9TWHZ0hzHrHfGH tB0waKeY7OVwi3dKeWegBkhgZjDCl2Ef990ME+SL8DEfaEGpQEZHUeNYfvD+DJTP WaJ5xenMvm3ZsCqajr+9X76O5/6PNGcHBHzdh6GFmIVinpe+1BKOhstKzjtx6+s9 iI0jPC5lDvR8qB0tigvAB31P5yi5J8I9nU6tC9eri4WvrKQe5EZxG9KpCxRE10ks WCnOOIGUie+6LfEZtLfiQXOasu8ZmcNeBKiF0Ahl6RMO6poz49Hmr7cOisSMxlze eXTwkOYfmFtE4rosnqpPAC+cYxATTNESWe2b3ZFg9Dbf1y2ROzkXKMe6naUZHc5q NWhoWw=3D=3D =3DVXPt -----END PGP PUBLIC KEY BLOCK----- --------------030805080401000908060906-- --------------enigA81BDCC464C6403861A9A5E2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOly7HAAoJELcEx/G14aEWzzEP/07RsNYNebqDgOe74S3KMlG5 ueFteJpmDswPxPuK6UsiphnXW0BssIp56p1QeFkhsiLji/PPBFdoYFQjf7+RYwHw rn71cAeuB3n49XzIOjB0Q9xcEb700Nb50PgsreoV5O6Bo/7lIbehZ4IV7FObadhx nQdU/NgtVdhe4L+R3H8cSkBKRTq9mOmchPmufKuve2CjVG9343b0/eQNY1H90IH2 1X+EG29w1gJSpbCAp41jT3TSz5lwr+maMrjJOGBN7IN1+5h1WUj8UBmM5LLfL21y psuso3nEJNAkl49PlBaEXr96CFYZvdlCJcotPvX3mZiGuzrZVwTQGFvI0NNvz30O 5b3GMMoTKfKlbnstgm9SvXyXP0NfQ3iaNx6mPIiROh85VjDnAIveDNSgvdby5xEF BB5d5w321sABCyCcpdIAhf53mkVClJY0RXmgNwerKZbqG8x//ka2YlNTHoFUr/Jn YiKzrvnslQ2Apj22OjzGeUK2+w/fSy7V/LYy3VqnO8tIyZjLkstIC3JZ9Qi8SHDP oCvmc6BZFXKy50x3NaXBixpwFO9s/4kUGecQXBV2hZeDPQ5ShDYoGma2delEjbGT 2rTPczFThQObKqo8tHEHecMwibZvtFpLj21OM1s0bQmovhwOC5MGKHLkegoExBDx wc6aLpZjZYlEsgBqgTPr =oykE -----END PGP SIGNATURE----- --------------enigA81BDCC464C6403861A9A5E2--