Return-path: Received: from mga14.intel.com ([143.182.124.37]:49336 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab1JLIXq (ORCPT ); Wed, 12 Oct 2011 04:23:46 -0400 Date: Wed, 12 Oct 2011 10:26:58 +0200 From: Samuel Ortiz To: Dan Carpenter Cc: Intel Linux Wireless , "John W. Linville" , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] iwmc3200wifi: add a range check to iwm_cfg80211_get_key() Message-ID: <20111012082656.GA13878@sortiz-mobl> (sfid-20111012_102350_162375_36811163) References: <20111012081036.GA32384@elgon.mountain> MIME-Version: 1.0 In-Reply-To: <20111012081036.GA32384@elgon.mountain> Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Dan, On Wed, Oct 12, 2011 at 11:10:37AM +0300, Dan Carpenter wrote: > Smatch complains that "key_index" is capped at 5 in nl80211_get_key() > but iwm->keys[] only has 4 elements. I don't know if this is really > needed, but the other ->get_key() implementations seemed to check > for overflows so I've added a check here. > > Signed-off-by: Dan Carpenter Acked-by: Samuel Ortiz Cheers. Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.