Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:36823 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593Ab1JLTAs (ORCPT ); Wed, 12 Oct 2011 15:00:48 -0400 Date: Wed, 12 Oct 2011 14:50:34 -0400 From: "John W. Linville" To: Rajkumar Manoharan Cc: linux-wireless@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH] ath9k_hw: Fix ASPM L1 issue for AR9462 Message-ID: <20111012185034.GH18764@tuxdriver.com> (sfid-20111012_210052_533122_14110477) References: <1318226145-7772-1-git-send-email-rmanohar@qca.qualcomm.com> <20111012184043.GG18764@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20111012184043.GG18764@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Oct 12, 2011 at 02:40:44PM -0400, John W. Linville wrote: > On Mon, Oct 10, 2011 at 11:25:45AM +0530, Rajkumar Manoharan wrote: > > Because of not clearing Bit 14 of AR_WA, the ASPM L1 is not > > enabled when entering into sleep mode. AR9462 does not need > > bit 14 to be set. > > > > Cc: stable@kernel.org > > Signed-off-by: Rajkumar Manoharan > > CC [M] drivers/net/wireless/ath/ath9k/hw.o > drivers/net/wireless/ath/ath9k/hw.c: In function ‘__ath9k_hw_init’: > drivers/net/wireless/ath/ath9k/hw.c:544:2: error: implicit declaration of function ‘AR_SREV_9462’ > > Missing a patch dependency? I see that is defined by a series posted just before that -- one that hasn't even appeared in wireless-next yet. Cc: stable@kernel.org seems a bit inappropriate... That series needs rework anyway -- how about you just fold this one into that earlier series? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.