Message-ID: <4EAEA2C0.6050401@qca.qualcomm.com> (sfid-20111031_142946_871589_1A9FC229)
Date: Mon, 31 Oct 2011 15:29:36 +0200
From: Kalle Valo <kvalo@qca.qualcomm.com>
MIME-Version: 1.0
To: Raja Mani <rmani@qca.qualcomm.com>
CC: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/7] ath6kl: Invoke wow suspend/resume calls during PM
 operations
References: <1319539047-8756-1-git-send-email-rmani@qca.qualcomm.com> <1319539047-8756-6-git-send-email-rmani@qca.qualcomm.com> <4EAAAC61.405@qca.qualcomm.com> <4EAE705C.3090704@qca.qualcomm.com>
In-Reply-To: <4EAE705C.3090704@qca.qualcomm.com>
Content-Type: text/plain; charset="ISO-8859-1"
Sender: linux-wireless-owner@vger.kernel.org

On 10/31/2011 11:54 AM, Raja Mani wrote:
> On Friday 28 October 2011 06:51 PM, Kalle Valo wrote:
>> On 10/25/2011 01:37 PM, rmani@qca.qualcomm.com wrote:
>>
>>> +	if (wow&&  ath6kl_cfg80211_ready(ar)&&
>>> +	    test_bit(CONNECTED,&ar->flag)&&
>>> +	    ath6kl_hif_keep_pwr_caps(ar)) {
>>> +
>>> +		/* Flush all non control pkts in Tx path */
>>> +		ath6kl_tx_data_cleanup(ar);
>>> +
>>> +		ret = ath6kl_pm_wow_suspend(ar, wow);
>>> +		if (ret)
>>> +			return ret;
>>> +	}
>>
>> Forgot to mention: don't you also need to check for MMC_PM_WAKE_SDIO_IRQ
>> and also set it with sdio_set_host_pm_flags()?
> 
> I tested it in x86 machine. Wow suspend/resume works even without 
> setting MMC_PM_WAKE_SDIO_IRQ. Should i really handle it ?

Yes, you should. Otherwise firmware is not able to wake up the host.

Also you should both check that wake sdio irq supported by the sdio
controller. Otherwise we might enable WoW even in cases when sdio
controller doesn't support it and which would result in broken wow
functionality.

Kalle