Return-path: Received: from hqemgate03.nvidia.com ([216.228.121.140]:15625 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056Ab1K1TKT (ORCPT ); Mon, 28 Nov 2011 14:10:19 -0500 Subject: Re: [PATCH] net: rfkill: convert net/rfkill/* to use module_platform_driver() From: Rhyland Klein To: Axel Lin Cc: "linux-kernel@vger.kernel.org" , "John W. Linville" , Johannes Berg , "David S. Miller" , Antonio Ospite , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" In-Reply-To: <1322471704.2730.1.camel@phoenix> References: <1322471704.2730.1.camel@phoenix> Content-Type: text/plain; charset="UTF-8" Date: Mon, 28 Nov 2011 11:09:47 -0800 Message-ID: <1322507387.3888.1.camel@rklein-linux2> (sfid-20111128_201035_747945_55711858) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2011-11-28 at 01:15 -0800, Axel Lin wrote: > This patch converts the drivers in net/rfkill/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. > > Cc: "David S. Miller" > Cc: "John W. Linville" > Cc: Johannes Berg > Cc: Antonio Ospite > Cc: Rhyland Klein > Signed-off-by: Axel Lin > --- > net/rfkill/rfkill-gpio.c | 13 +------------ > net/rfkill/rfkill-regulator.c | 12 +----------- > 2 files changed, 2 insertions(+), 23 deletions(-) > > diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c > index 128677d..ca355e7 100644 > --- a/net/rfkill/rfkill-gpio.c > +++ b/net/rfkill/rfkill-gpio.c > @@ -220,18 +220,7 @@ static struct platform_driver rfkill_gpio_driver = { > }, > }; > > -static int __init rfkill_gpio_init(void) > -{ > - return platform_driver_register(&rfkill_gpio_driver); > -} > - > -static void __exit rfkill_gpio_exit(void) > -{ > - platform_driver_unregister(&rfkill_gpio_driver); > -} > - > -module_init(rfkill_gpio_init); > -module_exit(rfkill_gpio_exit); > +module_platform_driver(rfkill_gpio_driver); > > MODULE_DESCRIPTION("gpio rfkill"); > MODULE_AUTHOR("NVIDIA"); Gpio part looks good to me. Acked-by: Rhyland Klein