Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:37828 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732Ab1KXQuY (ORCPT ); Thu, 24 Nov 2011 11:50:24 -0500 Received: by ggnr5 with SMTP id r5so2731928ggn.19 for ; Thu, 24 Nov 2011 08:50:23 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1322153083.5366.26.camel@jlt3.sipsolutions.net> References: <1322062858-15276-1-git-send-email-mcgrof@qca.qualcomm.com> <1322062858-15276-3-git-send-email-mcgrof@qca.qualcomm.com> <1322153083.5366.26.camel@jlt3.sipsolutions.net> From: "Luis R. Rodriguez" Date: Thu, 24 Nov 2011 11:50:02 -0500 Message-ID: (sfid-20111124_175027_232023_BCACB9AA) Subject: Re: [RFC 2/5] cfg80211: add support to immediately apply reg settings To: Johannes Berg Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Nov 24, 2011 at 11:44 AM, Johannes Berg wrote: > On Wed, 2011-11-23 at 10:40 -0500, Luis R. Rodriguez wrote: >> It is useful to apply reguatory settings immediately. We already >> handle applying regulatory hints immediatey for most hints but >> for user hints and country IE hints we want to kick hardware >> immediately to make these changes take effect. This adds supports >> to let us kick hardware to make the changes take effect as soon >> as possible. > > Can't say I like this -- wouldn't we rather call the regulatory update > callback or so? I'm not a fan either, at first I considered doing that on the reg_notifier() but then that also means every driver must implement a reg_notifier() callback, or a new reg_apply() callback. If we do it within cfg80211 it means all drivers get this for free and that was the tradeoff I wanted to review through these RFCs. Unfortunately setting the tx power was the only thing I saw cfg80211 could do right now. I'm still "meh" about this too. Luis