Return-path: Received: from nbd.name ([46.4.11.11]:38221 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753050Ab1K0GZU (ORCPT ); Sun, 27 Nov 2011 01:25:20 -0500 Message-ID: <4ED1D7BE.7040401@openwrt.org> (sfid-20111127_072543_110057_930D0554) Date: Sun, 27 Nov 2011 13:25:02 +0700 From: Felix Fietkau MIME-Version: 1.0 To: Adrian Chadd CC: "Rafael J. Wysocki" , Senthil Balasubramanian , "Luis R. Rodriguez" , "John W. Linville" , Linus Torvalds , Linux Kernel Mailing List , Linux Wireless Subject: Re: [PATCH] ath9k: Revert change that broke AR928X on Acer Ferrari One References: <201111250203.29786.rjw@sisk.pl> <201111262232.46195.rjw@sisk.pl> <201111262337.43771.rjw@sisk.pl> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2011-11-27 8:16 AM, Adrian Chadd wrote: > Hm, considering the origina patch did this: > > /* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */ > - if (AR_SREV_9300_20_OR_LATER(ah)) > - REG_WRITE(ah, AR_WA, > - ah->WARegVal & ~AR_WA_D3_L1_DISABLE); > + if (!AR_SREV_9480(ah)) > + REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE); > > .. something tells me that perhaps the correct statement is: > > if (AR_SREV_9300_20_OR_LATER(ah) && !AR_SREV_9480(ah)) > REG_WRITE() ... > I checked again, the !AR_SREV_9480(ah) was intentionally removed in a later change, so using AR_SREV_9300_20_OR_LATER(ah) is correct. - Felix