Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:53087 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755892Ab1KHWbp (ORCPT ); Tue, 8 Nov 2011 17:31:45 -0500 Received: by iage36 with SMTP id e36so1058617iag.19 for ; Tue, 08 Nov 2011 14:31:45 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1320790500.23056.0.camel@jlt3.sipsolutions.net> References: <1299609930-14011-1-git-send-email-scott@netsplit.com> <1320790500.23056.0.camel@jlt3.sipsolutions.net> From: "Luis R. Rodriguez" Date: Tue, 8 Nov 2011 14:31:24 -0800 Message-ID: (sfid-20111108_233149_370417_7A4ECFDF) Subject: Re: [PATCH] net/wireless: add COUNTRY to to regulatory device uevent To: Johannes Berg Cc: Scott James Remnant , "John W. Linville" , linux-wireless@vger.kernel.org, Kay Sievers , Greg Kroah-Hartman , Sam Leffler , keybuk@google.com Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Nov 8, 2011 at 2:15 PM, Johannes Berg wrote: > On Tue, 2011-03-08 at 10:45 -0800, Scott James Remnant wrote: >> From: Scott James Remnant >> >> Regulatory devices issue change uevents to inform userspace of a need >> to call the crda tool; however these can often be sent before udevd is >> running, and were not previously included in the results of >> udevadm trigger (which requests a new change event using the /uevent >> attribute of the sysfs object). >> >> Add a uevent function to the device type which includes the COUNTRY >> information from the last request if it has yet to be processed, the >> case of multiple requests is already handled in the code by checking >> whether an unprocessed one is queued in the same manner and refusing >> to queue a new one. >> >> The existing udev rule continues to work as before. > > Luis points out that it looks like this caused the crash I reported > earlier today -- in the module exit path we have a use-after-free of > last_request now. Sent patch. Luis