Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:44360 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447Ab1KWOpa (ORCPT ); Wed, 23 Nov 2011 09:45:30 -0500 Date: Wed, 23 Nov 2011 09:42:59 -0500 From: "John W. Linville" To: "Luis R. Rodriguez" Cc: Timo Lindhorst , johannes@sipsolutions.net, linux-wireless@vger.kernel.org Subject: Re: [PATCH] cfg80211: Fix changing regulatory from userspace Message-ID: <20111123144258.GC2502@tuxdriver.com> (sfid-20111123_154534_625248_F382A2EA) References: <201111230330.11103.tlnd@online.de> <20111123143456.GB2502@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20111123143456.GB2502@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 23, 2011 at 09:34:56AM -0500, John W. Linville wrote: > On Wed, Nov 23, 2011 at 06:28:57AM -0800, Luis R. Rodriguez wrote: > > On Tue, Nov 22, 2011 at 6:30 PM, Timo Lindhorst wrote: > > > The commit de3584bd62d87b4c250129fbc46ca52c80330add - > > > "cfg80211: fix regulatory NULL dereference" prevents the regulatory > > > domain from being changed by user space. A wiphy is only present > > > if the request comes from driver or is set by country IE, thus > > > check only those cases. > > > > > > Signed-off-by: Timo Lindhorst > > > > Yup but at this point I'd prefer we revert the original patch instead > > given that the patch also had some other short comings. John is it too > > late? > > No, it isn't too late to revert it. But can we have a new fix soon? Hmmm...actually, the original patch was sent in the batch yesterday. And it was Cc: stable. It would be a lot less confusing to merge a correct fix on top (and Cc: stable on that too). What is wrong with this one? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.