MIME-Version: 1.0
In-Reply-To: <CAB3XZEcm_4kppAkQbp+HrBAgPSY5W1jiJ5qst2V5E+4x5TMHoA@mail.gmail.com>
References: <1320762970-6860-1-git-send-email-arik@wizery.com> <CAB3XZEcm_4kppAkQbp+HrBAgPSY5W1jiJ5qst2V5E+4x5TMHoA@mail.gmail.com>
From: Arik Nemtsov <arik@wizery.com>
Date: Tue, 8 Nov 2011 17:26:32 +0200
Message-ID: <CA+XVXffVM1LVhQJ9hN3q5hnVM7q5PrDT3moBe6P85PSyX-Eajw@mail.gmail.com> (sfid-20111108_162652_856313_BA72D5D8)
Subject: Re: [PATCH v3 1/2] wl12xx: configure probe-resp template according to notification
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-wireless-owner@vger.kernel.org

On Tue, Nov 8, 2011 at 17:13, Eliad Peller <eliad@wizery.com> wrote:
> On Tue, Nov 8, 2011 at 4:36 PM, Arik Nemtsov <arik@wizery.com> wrote:
>> When operating in AP-mode, replace our probe-response template when a
>> notification is recieved from mac80211. We preserve the "legacy" way of
>> configuring a probe-response according to beacon for IBSS mode and for
>> versions of hostapd that do not support this feature.
>>
>> Signed-off-by: Guy Eilam <guy@wizery.com>
>> Signed-off-by: Arik Nemtsov <arik@wizery.com>
>> ---
> [...]
>> +static int wl1271_ap_set_probe_resp_tmpl(struct wl1271 *wl, u32 rates)
>> +{
>> + ? ? ? struct sk_buff *skb;
>> + ? ? ? int ret;
>> +
>> + ? ? ? skb = ieee80211_proberesp_get(wl->hw, wl->vif);
>> + ? ? ? if (!skb)
>> + ? ? ? ? ? ? ? return -EINVAL;
>> +
>> + ? ? ? ret = wl1271_cmd_template_set(wl,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? CMD_TEMPL_AP_PROBE_RESPONSE,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? skb->data,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? skb->len, 0,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? rates);
>> +
>> + ? ? ? dev_kfree_skb(skb);
>> + ? ? ? return ret;
>> +}
>
> add a check for max template size?

There's already a check inside. There's a WARN_ON, and the template is
just truncated to the max size.