Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:60267 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848Ab1KPSkI convert rfc822-to-8bit (ORCPT ); Wed, 16 Nov 2011 13:40:08 -0500 Received: by yenq3 with SMTP id q3so1751yen.19 for ; Wed, 16 Nov 2011 10:40:08 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1321445323-71774-1-git-send-email-nbd@openwrt.org> <1321445323-71774-2-git-send-email-nbd@openwrt.org> Date: Wed, 16 Nov 2011 10:40:07 -0800 Message-ID: (sfid-20111116_194012_785911_D4B63DFD) Subject: Re: [PATCH 2/4] ath9k: rework power state handling From: Paul Stewart To: "Luis R. Rodriguez" Cc: Felix Fietkau , Felix Fietkau , "linux-wireless@vger.kernel.org" , "linville@tuxdriver.com" , Senthil Balasubramanian Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: In fact, could this be made contingent on whether there's an AP-mode interface, since the problem you're encountering seems to only be in AP mode? What troubles me, Felix, is your statement that " this series fixes some "PCI error" crashes". Does this mean that you haven't root-caused the problem, and that this may only partially mask it? -- Paul On Wed, Nov 16, 2011 at 10:23 AM, Luis R. Rodriguez wrote: > On Wed, Nov 16, 2011 at 10:16 AM, Felix Fietkau wrote: >> On 16.11.2011, at 18:42, "Luis R. Rodriguez" wrote: >> >>> On Wed, Nov 16, 2011 at 4:08 AM, Felix Fietkau wrote: >>>> Turning off the radio when mac80211 tells the driver that it's idle is not >>>> a good idea, as idle interfaces might still occasionally scan or send packets. >>>> The only time the radio can be safely turned off is when drv_stop has been >>>> called. In the mean time, use sc->ps_idle only to indicate network sleep vs >>>> full sleep. >>>> Move the LED GPIO changes out of the PCI suspend/resume path, the start/stop >>>> functions already take care of that. >>>> >>>> Signed-off-by: Felix Fietkau >>> >>> This set of patches are going to need some good amount of testing for >>> power impact. The benefits and gains need to be considered. I'll yield >>> to Senthil and Paul for final approval on this. >> >> One of the gains is that this series fixes some "PCI error" crashes >> on OpenWrt during hostapd restarts. > > Thanks for the clarification, I was expecting this to be the case, the > point I am trying to make though is that this "fix" itself may > introduce a regression for non-AP devices, specifically in terms of > power consumption and I'd like the stakeholders who do care about that > to review these changes carefully as well. The difficulty will be to > find a reasonable middle ground. > > ?Luis >