Return-path: Received: from emh01.mail.saunalahti.fi ([62.142.5.107]:33516 "EHLO emh01.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756718Ab1KOQoa (ORCPT ); Tue, 15 Nov 2011 11:44:30 -0500 Message-ID: <4EC29534.7010502@adurom.com> (sfid-20111115_174454_976800_7DAF4251) Date: Tue, 15 Nov 2011 18:37:08 +0200 From: Kalle Valo MIME-Version: 1.0 To: Sangwook Lee CC: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org, ralf@linux-mips.org, juhosg@openwrt.org, rodrigue@qca.qualcomm.com, linville@tuxdriver.com, rmanohar@qca.qualcomm.com, patches@linaro.org Subject: Re: [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h References: <1321356224-5053-1-git-send-email-sangwook.lee@linaro.org> In-Reply-To: <1321356224-5053-1-git-send-email-sangwook.lee@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Sangwook, On 11/15/2011 01:23 PM, Sangwook Lee wrote: > The patch series proposes to rename ath9k_platform.h to "ath_platform.h > This header file handles platform data used only for ath9k, > but it can used by ath6k as well. We can take "wl12xx.h" as > as a example. Please let us change this file name so that > other Atheors WLANs use this file for their own platform data ath9k and ath6kl are very different devices, I'm not sure if sharing a platfrom struct between the two is really a good idea. Most likely there is very little the two drivers can share. What are your plans here? I myself was thinking that we would have include/linux/ath6kl.h dedicated just for ath6kl. That would makes things simpler. Kalle