Subject: Re: [PATCH v3 2/3] nl80211: Pass probe response data to drivers
From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
In-Reply-To: <CA+XVXffzmfOPEqJ=LhAhXwAjAjBJKtQOnOsRMHW8stodm0saFw@mail.gmail.com> (sfid-20111108_170538_622778_6C5182D7)
References: <1320762928-6782-1-git-send-email-arik@wizery.com>
	 <1320762928-6782-2-git-send-email-arik@wizery.com>
	 <1320766360.24797.5.camel@jlt3.sipsolutions.net>
	 <CA+XVXffzmfOPEqJ=LhAhXwAjAjBJKtQOnOsRMHW8stodm0saFw@mail.gmail.com>
	 (sfid-20111108_170538_622778_6C5182D7)
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 08 Nov 2011 17:10:49 +0100
Message-ID: <1320768649.24797.15.camel@jlt3.sipsolutions.net> (sfid-20111108_171056_193036_D79D7F36)
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Tue, 2011-11-08 at 18:04 +0200, Arik Nemtsov wrote:
> On Tue, Nov 8, 2011 at 17:32, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Tue, 2011-11-08 at 16:35 +0200, Arik Nemtsov wrote:
> >> Pass probe-response data from usermode via beacon parameters.
> >>
> >> Signed-off-by: Guy Eilam <guy@wizery.com>
> >> Signed-off-by: Arik Nemtsov <arik@wizery.com>
> >> ---
> >> v1->3:
> >> Set the probe response data as part of the addset_beacon function, instead
> >> of set_bss. This makes more sense since the probe response is always
> >> updated with the beacon.
> >>
> >> include/linux/nl80211.h |    4 ++++
> >>  include/net/cfg80211.h  |    4 ++++
> >>  net/wireless/nl80211.c  |    9 +++++++++
> >>  3 files changed, 17 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
> >> index e74afc4..3fa03b3 100644
> >> --- a/include/linux/nl80211.h
> >> +++ b/include/linux/nl80211.h
> >> @@ -1114,6 +1114,8 @@ enum nl80211_commands {
> >>   *   In addition this attribute holds a bitmap of the supported protocols
> >>   *   for offloading using &enum nl80211_probe_resp_offload_support_attr.
> >>   *
> >> + * @NL80211_ATTR_PROBE_RESP: Probe Response template data
> >> + *
> >
> > That should say what kind of data is expected -- I think a full frame in
> > this case? Should it really be a full frame though? Maybe ath6kl
> > requires something else and we can make this somehow compatible with
> > both?
> 
> I can be more verbose in the description, sure. The probe-resp IEs are
> a subset of the full probe-resp template, so I guess we could give ath6kl a
> start_pos, end_pos into the full probe_resp buffer.
> 
> But IMHO it's cleaner the way it is now.

Agree, thanks for explaining (and on IRC too).

johannes