Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:51442 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247Ab1K1TAk (ORCPT ); Mon, 28 Nov 2011 14:00:40 -0500 Date: Mon, 28 Nov 2011 13:45:06 -0500 From: "John W. Linville" To: "Luis R. Rodriguez" Cc: Timo Lindhorst , johannes@sipsolutions.net, linux-wireless@vger.kernel.org Subject: Re: [PATCH] cfg80211: Fix changing regulatory from userspace Message-ID: <20111128184506.GC2681@tuxdriver.com> (sfid-20111128_200049_326006_208F3B8B) References: <201111230330.11103.tlnd@online.de> <20111123143456.GB2502@tuxdriver.com> <20111123144258.GC2502@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 23, 2011 at 06:58:00AM -0800, Luis R. Rodriguez wrote: > On Wed, Nov 23, 2011 at 6:42 AM, John W. Linville > wrote: > > On Wed, Nov 23, 2011 at 09:34:56AM -0500, John W. Linville wrote: > >> On Wed, Nov 23, 2011 at 06:28:57AM -0800, Luis R. Rodriguez wrote: > >> > On Tue, Nov 22, 2011 at 6:30 PM, Timo Lindhorst wrote: > >> > > The commit de3584bd62d87b4c250129fbc46ca52c80330add - > >> > > "cfg80211: fix regulatory NULL dereference" prevents the regulatory > >> > > domain from being changed by user space. A wiphy is only present > >> > > if the request comes from driver or is set by country IE, thus > >> > > check only those cases. > >> > > > >> > > Signed-off-by: Timo Lindhorst > >> > > >> > Yup but at this point I'd prefer we revert the original patch instead > >> > given that the patch also had some other short comings. John is it too > >> > late? > >> > >> No, it isn't too late to revert it. ?But can we have a new fix soon? > > > > Hmmm...actually, the original patch was sent in the batch yesterday. > > And it was Cc: stable. ?It would be a lot less confusing to merge a > > correct fix on top (and Cc: stable on that too). ?What is wrong with > > this one? > > This one is a correct fix to one of the issues present in the original > patch, the other issue is the original patch overlooks the fact that > last_request would be left with stale data. Let me post my fixes as > RFCs on top of Johannes's original patch to clarify. Unfortunately > this doesn't have much testing but I'll post for review at least. Looks like the RFCs got some comments. Will there be a respin of those? Or should I just apply this one for now? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.