Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:38986 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598Ab1K1VrY (ORCPT ); Mon, 28 Nov 2011 16:47:24 -0500 From: "Luis R. Rodriguez" To: linville@tuxdriver.com, johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, "Luis R. Rodriguez" , stable@vger.kernel.org, Johannes Berg Subject: [PATCH v3 2/2] cfg80211: amend regulatory NULL dereference fix Date: Mon, 28 Nov 2011 16:47:16 -0500 Message-Id: <1322516836-5474-2-git-send-email-mcgrof@qca.qualcomm.com> (sfid-20111128_224728_164669_4E3975C2) In-Reply-To: <1322516836-5474-1-git-send-email-mcgrof@qca.qualcomm.com> References: <1322516836-5474-1-git-send-email-mcgrof@qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes' patch for "cfg80211: fix regulatory NULL dereference" broke user regulaotry hints and it did not address the fact that last_request was left populated even if the previous regulatory hint was stale due to the wiphy disappearing. Fix user reguluatory hints by only bailing out if for those regulatory hints where a request_wiphy is expected. The stale last_request considerations are addressed through the previous fixes on last_request where we reset the last_request to a static world regdom request upon reset_regdomains(). In this case though we further enhance the effect by simply restoring reguluatory settings completely. Cc: stable@vger.kernel.org Cc: Johannes Berg Signed-off-by: Luis R. Rodriguez --- net/wireless/reg.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index a5f0ac7..70b171a 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -2090,8 +2090,10 @@ static int __set_regdom(const struct ieee80211_regdomain *rd) } request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx); - if (!request_wiphy) { - reg_set_request_processed(); + if (!request_wiphy && + (last_request->initiator == NL80211_REGDOM_SET_BY_DRIVER || + last_request->initiator == NL80211_REGDOM_SET_BY_COUNTRY_IE)) { + schedule_delayed_work(®_timeout, 0); return -ENODEV; } -- 1.7.4.15.g7811d