Return-path: Received: from mail-ee0-f46.google.com ([74.125.83.46]:37564 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274Ab1LHSQd (ORCPT ); Thu, 8 Dec 2011 13:16:33 -0500 Message-ID: <1323368188.2529.4.camel@edumazet-laptop> (sfid-20111208_191638_501511_8A97CE51) Subject: Re: [PATCH net-next] sch_red: Adaptative RED AQM From: Eric Dumazet To: Stephen Hemminger Cc: Dave Taht , David Miller , linux-wireless , netdev@vger.kernel.org, Hagen Paul Pfeifer , bloat-devel , bloat Date: Thu, 08 Dec 2011 19:16:28 +0100 In-Reply-To: <20111208092130.656c39ff@nehalam.linuxnetplumber.net> References: <1323082774.2670.40.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1323360363.2521.30.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111208092130.656c39ff@nehalam.linuxnetplumber.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Le jeudi 08 décembre 2011 à 09:21 -0800, Stephen Hemminger a écrit : > Is this backward compatible for users that don't specify > an adaptive parameter. Yes, completely compatible. I made sure max_p was initted with value provided by tc (Plog based) I also plan the TCA_RED_MAX_P support at configuration time with finer granularity than 1/(2^Plog), so a new tc user can ask for precise probability instead of current few discrete values. [ for non adaptative RED of course, since max_p can change very fast otherwise :) ]