Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:60080 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896Ab1LFUU6 convert rfc822-to-8bit (ORCPT ); Tue, 6 Dec 2011 15:20:58 -0500 Received: by eaak14 with SMTP id k14so5543277eaa.19 for ; Tue, 06 Dec 2011 12:20:56 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20111206200434.GE30288@tuxdriver.com> References: <1321445323-71774-1-git-send-email-nbd@openwrt.org> <1321445323-71774-2-git-send-email-nbd@openwrt.org> <4EC44CC6.7090104@openwrt.org> <20111206200434.GE30288@tuxdriver.com> Date: Tue, 6 Dec 2011 12:20:55 -0800 Message-ID: (sfid-20111206_212107_311840_2D48281D) Subject: Re: [PATCH 2/4] ath9k: rework power state handling From: Paul Stewart To: "John W. Linville" Cc: Felix Fietkau , "Luis R. Rodriguez" , "linux-wireless@vger.kernel.org" , Senthil Balasubramanian Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: I haven't had time to do set up power draw testing. You can put it in, but we may revisit this when those are done. If you have power consumption figures of your own, that'd help. -- Paul On Tue, Dec 6, 2011 at 12:04 PM, John W. Linville wrote: > On Thu, Nov 17, 2011 at 12:52:38AM +0100, Felix Fietkau wrote: >> On 2011-11-16 7:40 PM, Paul Stewart wrote: >> > In fact, could this be made contingent on whether there's an AP-mode >> > interface, since the problem you're encountering seems to only be in >> > AP mode? ?What troubles me, Felix, is your statement that " this >> > series fixes some "PCI error" crashes". ?Does this mean that you >> > haven't root-caused the problem, and that this may only partially mask >> > it? >> The existing code was wrong, especially for client mode. I only noticed >> that because I was investigating some AP mode crashes triggered by it. >> My main focus when fixing this stuff was actually client mode since >> that's the one most affected by this codepath. > > Are we satisfied w/ this series? ?Or does it still need work? > > John > -- > John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you > linville@tuxdriver.com ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.