Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:39782 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752668Ab2ACMYi (ORCPT ); Tue, 3 Jan 2012 07:24:38 -0500 Date: Tue, 3 Jan 2012 12:24:24 +0000 From: Matthew Garrett To: Linus Torvalds Cc: Alan Stern , Jack Stone , Oliver Neukum , Dave Jones , Linux Kernel , Larry Finger , Chaoming Li , "John W. Linville" , Greg Kroah-Hartman , USB list , Linux Wireless List Subject: Re: loading firmware while usermodehelper disabled. Message-ID: <20120103122424.GA24367@srcf.ucam.org> (sfid-20120103_132452_841071_7A1A06C9) References: <20120102215028.GA15701@srcf.ucam.org> <20120103032505.GA19702@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 02, 2012 at 09:53:46PM -0800, Linus Torvalds wrote: > On Mon, Jan 2, 2012 at 7:25 PM, Matthew Garrett wrote: > > On Mon, Jan 02, 2012 at 09:45:58PM -0500, Alan Stern wrote: > > > >> Wait a second. ?Why does isight_firmware bind at this time? ?Binding to > >> new devices is handled by khubd, which doesn't start running again > >> until after the resume is finished (the device appears to be new > >> because its descriptors have changed). ?At that point there should be > >> no trouble reloading the firmware. > > > > Then why are we getting this warning? The firmware is only loaded in the > > probe function. > > The USB suspend/resume function does that "unbind/rebind" dance, and > that causes a "device_attach()". Which causes a probe() to be called. > > Should it do that? I think not, not if the ID's haven't changed. But I > don't know the USB layer all that well. The IDs will have changed due to the firmware falling out. -- Matthew Garrett | mjg59@srcf.ucam.org