Return-path: Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:35690 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560Ab2AZMmj (ORCPT ); Thu, 26 Jan 2012 07:42:39 -0500 Received: by mail-yw0-f43.google.com with SMTP id g71so190658yhg.2 for ; Thu, 26 Jan 2012 04:42:38 -0800 (PST) From: Victor Goldenshtein To: Cc: , , , , , , , , , , , , Subject: [RFC 4/7] hostapd: add dfs support into interface init flow Date: Thu, 26 Jan 2012 14:41:26 +0200 Message-Id: <1327581689-22090-5-git-send-email-victorg@ti.com> (sfid-20120126_134241_640732_10A15C9D) In-Reply-To: <1327581689-22090-1-git-send-email-victorg@ti.com> References: <1327581689-22090-1-git-send-email-victorg@ti.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Implement Channel Availability Check (CAC) during initialization phase. According to DFS requirements the AP should monitor 'radar channels' for potential radar interference for a minimum CAC time prior enabling the transmissions. Add dfs support into hw features, allow the usage of the radar channels if ieee80211h is enabled in the hostapd.conf and the driver supports radar detection. Parse and handle driver's DFS capabilities, userspace applications must be fully synchronized with device capabilities to detect radar patterns in the air which may influence userspace behavior. Signed-off-by: Boris Presman Signed-off-by: Victor Goldenshtein --- src/ap/hostapd.c | 17 +++++++++++------ src/ap/hw_features.c | 30 ++++++++++++++++++++---------- src/ap/hw_features.h | 9 +++++++++ src/drivers/driver.h | 5 +++++ src/drivers/driver_nl80211.c | 7 +++++++ src/utils/eloop.c | 4 ++++ src/utils/eloop.h | 7 +++++++ 7 files changed, 63 insertions(+), 16 deletions(-) diff --git a/src/ap/hostapd.c b/src/ap/hostapd.c index ce37922..411b681 100644 --- a/src/ap/hostapd.c +++ b/src/ap/hostapd.c @@ -708,6 +708,12 @@ static int setup_interface(struct hostapd_iface *iface) "be completed in a callback"); return 0; } + + if (iface->current_mode->dfs_supported && + iface->conf->ieee80211h) { + wpa_printf(MSG_DEBUG, "DFS support is enabled"); + iface->dfs_state |= DFS_ENABLED; + } } return hostapd_setup_interface_complete(iface, 0); } @@ -733,14 +739,13 @@ int hostapd_setup_interface_complete(struct hostapd_iface *iface, int err) hostapd_hw_mode_txt(hapd->iconf->hw_mode), hapd->iconf->channel, iface->freq); - if (hostapd_set_freq(hapd, hapd->iconf->hw_mode, iface->freq, - hapd->iconf->channel, - hapd->iconf->ieee80211n, - hapd->iconf->secondary_channel)) { - wpa_printf(MSG_ERROR, "Could not set channel for " - "kernel driver"); + if (hostapd_check_set_freq(hapd)) { + wpa_printf(MSG_ERROR, "Couldn't check/set freq"); return -1; } + + eloop_enable(); + wpa_printf(MSG_DEBUG, "Continuing with init flow"); } if (iface->current_mode) { diff --git a/src/ap/hw_features.c b/src/ap/hw_features.c index d64fbeb..1804978 100644 --- a/src/ap/hw_features.c +++ b/src/ap/hw_features.c @@ -70,26 +70,36 @@ int hostapd_get_hw_features(struct hostapd_iface *iface) for (i = 0; i < num_modes; i++) { struct hostapd_hw_modes *feature = &modes[i]; + u8 dfs_enabled = (hapd->iconf->ieee80211h && + feature->dfs_supported); /* set flag for channels we can use in current regulatory * domain */ for (j = 0; j < feature->num_channels; j++) { + u8 dfs = FALSE; /* * Disable all channels that are marked not to allow - * IBSS operation or active scanning. In addition, - * disable all channels that require radar detection, - * since that (in addition to full DFS) is not yet - * supported. + * IBSS operation or active scanning. + * Use radar channels only if the driver supports + * DFS. */ - if (feature->channels[j].flag & - (HOSTAPD_CHAN_NO_IBSS | - HOSTAPD_CHAN_PASSIVE_SCAN | - HOSTAPD_CHAN_RADAR)) + if ((feature->channels[j].flag & + HOSTAPD_CHAN_RADAR) && dfs_enabled) { + dfs = TRUE; + } else if (feature->channels[j].flag & + (HOSTAPD_CHAN_NO_IBSS | + HOSTAPD_CHAN_PASSIVE_SCAN | + HOSTAPD_CHAN_DISABLED)) { feature->channels[j].flag |= HOSTAPD_CHAN_DISABLED; - if (feature->channels[j].flag & HOSTAPD_CHAN_DISABLED) + } + + if (feature->channels[j].flag & HOSTAPD_CHAN_DISABLED) { continue; - wpa_printf(MSG_MSGDUMP, "Allowed channel: mode=%d " + } + + wpa_printf(MSG_WARNING, "Allowed %schannel: mode=%d " "chan=%d freq=%d MHz max_tx_power=%d dBm", + dfs ? "(DFS) " : "", feature->mode, feature->channels[j].chan, feature->channels[j].freq, diff --git a/src/ap/hw_features.h b/src/ap/hw_features.h index c8a7f60..a8442b5 100644 --- a/src/ap/hw_features.h +++ b/src/ap/hw_features.h @@ -46,6 +46,11 @@ static inline int hostapd_select_hw_mode(struct hostapd_iface *iface) return -100; } +static inline int hostapd_select_radar_detector(struct hostapd_iface *iface) +{ + return -1; +} + static inline const char * hostapd_hw_mode_txt(int mode) { return NULL; @@ -67,6 +72,10 @@ static inline int hostapd_prepare_rates(struct hostapd_iface *iface, return 0; } +static inline int hostapd_get_channel_flag(struct hostapd_data *hapd, int chan) +{ + return 0; +} #endif /* NEED_AP_MLME */ #endif /* HW_FEATURES_H */ diff --git a/src/drivers/driver.h b/src/drivers/driver.h index 68bf2e7..ed256d2 100644 --- a/src/drivers/driver.h +++ b/src/drivers/driver.h @@ -110,6 +110,11 @@ struct hostapd_hw_modes { u8 a_mpdu_params; unsigned int flags; /* HOSTAPD_MODE_FLAG_* */ + + /** + * dfs_supported - DFS radar detection is supported in driver/HW. + */ + u8 dfs_supported; }; diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 82f5664..f1e6ca2 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -4692,6 +4692,13 @@ static int phy_info_handler(struct nl_msg *msg, void *arg) mode->flags = HOSTAPD_MODE_FLAG_HT_INFO_KNOWN; *(phy_info->num_modes) += 1; + if (tb_msg[NL80211_ATTR_FEATURE_FLAGS]) { + u32 drv_feature_flags = + nla_get_u32(tb_msg[NL80211_ATTR_FEATURE_FLAGS]); + mode->dfs_supported = !!(drv_feature_flags & + NL80211_FEATURE_DFS); + } + nla_parse(tb_band, NL80211_BAND_ATTR_MAX, nla_data(nl_band), nla_len(nl_band), NULL); diff --git a/src/utils/eloop.c b/src/utils/eloop.c index b550c63..9f1fb34 100644 --- a/src/utils/eloop.c +++ b/src/utils/eloop.c @@ -576,6 +576,10 @@ void eloop_terminate(void) eloop.terminate = 1; } +void eloop_enable(void) +{ + eloop.terminate = 0; +} void eloop_destroy(void) { diff --git a/src/utils/eloop.h b/src/utils/eloop.h index a656bf8..0aeb0f0 100644 --- a/src/utils/eloop.h +++ b/src/utils/eloop.h @@ -287,6 +287,13 @@ void eloop_run(void); void eloop_terminate(void); /** + * eloop_enable - Enable event loop + * + * Enables the event loop. + */ +void eloop_enable(void); + +/** * eloop_destroy - Free any resources allocated for the event loop * * After calling eloop_destroy(), other eloop_* functions must not be called -- 1.7.5.4