Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:50391 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606Ab2ABWMn (ORCPT ); Mon, 2 Jan 2012 17:12:43 -0500 Date: Mon, 2 Jan 2012 22:12:36 +0000 From: Matthew Garrett To: Linus Torvalds Cc: Jack Stone , Alan Stern , Oliver Neukum , Dave Jones , Linux Kernel , Larry Finger , Chaoming Li , "John W. Linville" , Greg Kroah-Hartman , USB list , Linux Wireless List Subject: Re: loading firmware while usermodehelper disabled. Message-ID: <20120102221235.GA16012@srcf.ucam.org> (sfid-20120102_231326_850340_41A3DC8F) References: <4F02165C.1060400@fastmail.fm> <20120102211904.GA15316@srcf.ucam.org> <20120102215028.GA15701@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 02, 2012 at 02:03:27PM -0800, Linus Torvalds wrote: > On Mon, Jan 2, 2012 at 1:50 PM, Matthew Garrett wrote: > > On Mon, Jan 02, 2012 at 01:27:03PM -0800, Linus Torvalds wrote: > > > >> If we didn't load the firmware before the suspend, then the resume > >> function of a device sure as hell had better not load it at resume > >> time either. > > > > If the hardware has lost its state then refusing to load the firmware at > > resume time isn't going to leave you with a working device. > > What the heck is your problem? > > Go back and read it. > > If it wasn't loaded before, THEN IT WASN'T WORKING BEFORE EITHER! And > if it was loaded before, then it would be cached (and thus trivially > reloaded without having to invoke user-space or disk devices that may > not be running) and thus loading it would work. The kernel that loaded the firmware to make the device work is not required to be the same kernel that we're running when we suspend. The hardware keeps its firmware over warm reboots, and if it already has loaded firmware then we have no way of knowing that it needs firmware at all. -- Matthew Garrett | mjg59@srcf.ucam.org