Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:34257 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753985Ab2ACQ33 (ORCPT ); Tue, 3 Jan 2012 11:29:29 -0500 MIME-Version: 1.0 In-Reply-To: <20120103122424.GA24367@srcf.ucam.org> References: <20120102215028.GA15701@srcf.ucam.org> <20120103032505.GA19702@srcf.ucam.org> <20120103122424.GA24367@srcf.ucam.org> From: Linus Torvalds Date: Tue, 3 Jan 2012 08:29:07 -0800 Message-ID: (sfid-20120103_172938_354183_24C6A4EB) Subject: Re: loading firmware while usermodehelper disabled. To: Matthew Garrett Cc: Alan Stern , Jack Stone , Oliver Neukum , Dave Jones , Linux Kernel , Larry Finger , Chaoming Li , "John W. Linville" , Greg Kroah-Hartman , USB list , Linux Wireless List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Jan 3, 2012 at 4:24 AM, Matthew Garrett wrote: > > The IDs will have changed due to the firmware falling out. The thing is, I don't think it has. You said this used to work. And I suspect that the ID's haven't changed at all. The unbind/rebind kind of supports that (it shouldn't re-bind if it's not the same device, afaik). I suspect the bug report is from a system that didn't actually have the firmware loaded even before the suspend (so no USB ID changes, just the stupid unbind/rebind). Of course, it's possible that it "used to work" just because we used to have that "we'll try to load things even if user space isn't ready", which caused 30-second timeouts for the random cases where it didn't work, but also silently "just worked" for the other random cases where it did happen to work. But I don't think unbind/rebind is correct for an ID change, so that really doesn't make sense as a explanation either (at least for *this* particular bug report). Linus